On 2019-01-17 16:06, Andy Herrick wrote:
If I remove the line -nologo from lib-jdk.jpackage.gmk:
69 LDFLAGS_windows := -nologo, \
I get the logo during build (same with console andnon-console version):
Microsoft (R) Incremental Linker Version 14.12.25835.0
Copyright (C) Microsoft
Hi Andy,
This is looking really sweet from a build perspective!
Just a few minor nits:
* In Launcher-jdk.jpackage.gmk, please indent the else clause ("$(eval
$(call SetupBuildLauncher, jpackage ") two spaces.
* In Lib-jdk.jpackage.gmk, I think there's still room to prune some more
