Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-05 Thread Naoto Sato
Thanks, Magnus. The change looks good to me too. Naoto On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote: On 2019-02-01 14:43, naoto.s...@oracle.com wrote: Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Yes. I have verified this

Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-05 Thread Magnus Ihse Bursie
On 2019-02-01 14:43, naoto.s...@oracle.com wrote: Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Yes. I have verified this using the COMPARE_BUILD functionality. /Magnus Naoto On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote: The

Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread Erik Joelsson
Looks good. /Erik On 2019-02-01 02:50, Magnus Ihse Bursie wrote: The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project. This patch aims to

Re: RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread naoto . sato
Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Naoto On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote: The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between

RFR: JDK-8218186 Clean up CLDR generation in build

2019-02-01 Thread Magnus Ihse Bursie
The CLDR data is, since Jigsaw, used in two different modules -- java.base and jdk.localedata. Unfortunately, the split between these two modules were not fully finished as part of the Jigsaw project. This patch aims to resolving most of this. The CLDRConverter build tool is now called from