Re: RFR: JDK-8239794 Move -Os from JVM feature 'minimal' to new feature 'opt-size'

2020-02-23 Thread David Holmes
Hi Magnus, This seems reasonable to me. The definition of OPT_SPEED_SRC is likely out of date, but we have no data for modifying that list. People who try opt-size will likely try to refine it. Thanks, David - On 22/02/2020 2:13 am, Magnus Ihse Bursie wrote: Prior to JDK-8239450, it was

Re: RFR: JDK-8239794 Move -Os from JVM feature 'minimal' to new feature 'opt-size'

2020-02-21 Thread Erik Joelsson
Looks good to me. /Erik On 2020-02-21 08:13, Magnus Ihse Bursie wrote: Prior to JDK-8239450, it was possible to explicitly set the JVM feature 'minimal', even when building variant server. The reason for doing this was to get the code in JvmFeatures.gmk that sets JVM_OPTIMIZATION := SIZE (exc

RFR: JDK-8239794 Move -Os from JVM feature 'minimal' to new feature 'opt-size'

2020-02-21 Thread Magnus Ihse Bursie
Prior to JDK-8239450, it was possible to explicitly set the JVM feature 'minimal', even when building variant server. The reason for doing this was to get the code in JvmFeatures.gmk that sets JVM_OPTIMIZATION := SIZE (except for a handful of files). Since this functionality is important in it