Re: RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

2020-04-21 Thread Magnus Ihse Bursie
On 2020-04-20 21:19, Joe Darcy wrote: Hello, On 4/16/2020 5:47 AM, Magnus Ihse Bursie wrote: [snip] The tricky one here is the helper TableModelComparator. This one took me a while to wrap my head around. It implements Comparator, but the compare() method takes "rows" from the model, which

Re: RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

2020-04-20 Thread David Holmes
Hi Magnus, That all seems reasonable to me. Thanks, David - On 16/04/2020 10:47 pm, Magnus Ihse Bursie wrote: This is the final part of removing all warnings from the build of jdk.hotspot.agent. This patch includes a number of non-trivial fixes for the few remaining unchecked warnings.

Re: RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

2020-04-20 Thread serguei.spit...@oracle.com
Hi Magnus, This looks pretty good to me. I hope, Joe gave some insight for Comparable's. Thanks, Serguei On 4/16/20 05:47, Magnus Ihse Bursie wrote: This is the final part of removing all warnings from the build of jdk.hotspot.agent. This patch includes a number of non-trivial fixes for the

Re: RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

2020-04-20 Thread Joe Darcy
Hello, On 4/16/2020 5:47 AM, Magnus Ihse Bursie wrote: [snip] The tricky one here is the helper TableModelComparator. This one took me a while to wrap my head around. It implements Comparator, but the compare() method takes "rows" from the model, which are just expressed as Objects, and left t

RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

2020-04-16 Thread Magnus Ihse Bursie
This is the final part of removing all warnings from the build of jdk.hotspot.agent. This patch includes a number of non-trivial fixes for the few remaining unchecked warnings. The good news is that with this fix (and after the recent removal of Nashorn and rmic), the JDK build is finally comp