Re: RFR: JDK-8243156 Fix deprecation and unchecked warnings in microbenchmark

2020-04-20 Thread Claes Redestad
I've looked at the benchmarks that move from explicit constructors to autoboxing and don't think we'll see any difference in behavior: all usage during setup, and benchmarks don't seem to accidentally depend on identity. LGTM. /Claes On 2020-04-20 15:01, Erik Joelsson wrote: This looks good to

Re: RFR: JDK-8243156 Fix deprecation and unchecked warnings in microbenchmark

2020-04-20 Thread Erik Joelsson
This looks good to me, but I would like to hear from someone who knows the benchmarks to confirm that nothing relevant to the tests was lost when introducing autoboxing instead of explicit constructors in any of the cases. /Erik On 2020-04-20 04:51, Magnus Ihse Bursie wrote: This patch addres

RFR: JDK-8243156 Fix deprecation and unchecked warnings in microbenchmark

2020-04-20 Thread Magnus Ihse Bursie
This patch addresses the warnings deprecation and unchecked, which are impossible to fully suppress. With this patch, the test-image can be built fully without warnings. The patch updates non-critical code to use modern solutions for deprecated methods, where possible. Tested methods have been