Re: RFR: JDK-8257547: Handle multiple prereqs on the same line in deps files [v2]

2020-12-02 Thread Tim Bell
On Wed, 2 Dec 2020 21:41:26 GMT, Erik Joelsson wrote: >> test/make/TestFixDepsFile.gmk line 60: >> >>> 58: $(ECHO) " $(WORKSPACE_ROOT)/bar/baz \\" >> $(DEPS_FILE).expected >>> 59: $(ECHO) " /foo/baz" >> $(DEPS_FILE).expected >>> 60: $(DIFF) $(DEPS_FILE).expected

Re: RFR: JDK-8257547: Handle multiple prereqs on the same line in deps files [v2]

2020-12-02 Thread Erik Joelsson
On Wed, 2 Dec 2020 20:01:08 GMT, Tim Bell wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added test > > test/make/TestFixDepsFile.gmk line 60: > >> 58: $(ECHO) " $(WORKSPACE_ROOT)/bar/baz \\" >>

Re: RFR: JDK-8257547: Handle multiple prereqs on the same line in deps files [v2]

2020-12-02 Thread Tim Bell
On Wed, 2 Dec 2020 17:55:18 GMT, Erik Joelsson wrote: >> After fixing JDK-8256810 and starting to look into backporting it, I >> discovered more potential failing cases. Certain versions of GCC may >> sometimes output multiple prerequisite files on the same line. I think the >> easiest way to

Re: RFR: JDK-8257547: Handle multiple prereqs on the same line in deps files [v2]

2020-12-02 Thread Erik Joelsson
> After fixing JDK-8256810 and starting to look into backporting it, I > discovered more potential failing cases. Certain versions of GCC may > sometimes output multiple prerequisite files on the same line. I think the > easiest way to handle this new issue is to split such lines. > > When