Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-17 Thread Thiwa Chantarangkul

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v5]

2022-02-16 Thread Alan Bateman
On Wed, 16 Feb 2022 17:55:55 GMT, Tim Prinzing wrote: >> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null > > Tim Prinzing has updated the pull request incrementally with one additional > commit since the last revision: > > fix copyright date Marked as reviewed by alanb (Revi

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v5]

2022-02-16 Thread Tim Prinzing
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision: fix copyright date - Changes: - all: https://git.openjdk.java.net/jdk/pull/7447/files - new: https://

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v4]

2022-02-15 Thread Mandy Chung
On Tue, 15 Feb 2022 00:10:44 GMT, Tim Prinzing wrote: >> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null > > Tim Prinzing has updated the pull request incrementally with one additional > commit since the last revision: > > remove excess description Looks good. -

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v4]

2022-02-14 Thread Tim Prinzing
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision: remove excess description - Changes: - all: https://git.openjdk.java.net/jdk/pull/7447/files - new: h

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v3]

2022-02-14 Thread Tim Prinzing
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision: missing dot - Changes: - all: https://git.openjdk.java.net/jdk/pull/7447/files - new: https://git.ope

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null [v2]

2022-02-14 Thread Tim Prinzing
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision: Changes from feedback. - Improved javadoc. - Single copyright date in new files. - Informative string in excep

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread John R Rose
On Mon, 14 Feb 2022 18:10:37 GMT, Alan Bateman wrote: >> `MethodHandles::publicLookup` can be called instead to get a public Lookup >> to invoke a method with a Lookup parameter. The dilemma here is whether >> the API should be made null-caller friendly or using a proper API >> `MethodHandle

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread John R Rose
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote: > JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Marked as reviewed by jrose (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7447

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Mandy Chung
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote: > JDK-8281003 - MethodHandles::lookup throws NPE if caller is null This needs a CSR and the spec needs update. The test name could be shortened to `s/exeNullCallerMethodHandlesLookup/exeNullCallerLookup/`. src/java.base/share/classes/jav

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Mandy Chung
On Mon, 14 Feb 2022 18:28:09 GMT, Mandy Chung wrote: >> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null > > src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121: > >> 119: Class c = Reflection.getCallerClass(); >> 120: if (c == null) { >> 121:

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Alan Bateman
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote: > JDK-8281003 - MethodHandles::lookup throws NPE if caller is null test/jdk/java/lang/invoke/MethodHandles/exeNullCallerMethodHandlesLookup/NullCallerMethodHandlesLookupTest.java line 2: > 1: /* > 2: * Copyright (c) 2019, 2022, Oracle and/

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Alan Bateman
On Mon, 14 Feb 2022 18:03:45 GMT, Mandy Chung wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121: >> >>> 119: Class c = Reflection.getCallerClass(); >>> 120: if (c == null) { >>> 121: throw new IllegalCallerException(); >> >> Throwing

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Mandy Chung
On Mon, 14 Feb 2022 11:56:16 GMT, Alan Bateman wrote: >> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null > > src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121: > >> 119: Class c = Reflection.getCallerClass(); >> 120: if (c == null) { >> 121

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Magnus Ihse Bursie
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote: > JDK-8281003 - MethodHandles::lookup throws NPE if caller is null Build changes are OK - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7447

Re: RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-14 Thread Alan Bateman
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote: > JDK-8281003 - MethodHandles::lookup throws NPE if caller is null src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121: > 119: Class c = Reflection.getCallerClass(); > 120: if (c == null) { > 121:

RFR: JDK-8281003 - MethodHandles::lookup throws NPE if caller is null

2022-02-11 Thread Tim Prinzing
JDK-8281003 - MethodHandles::lookup throws NPE if caller is null - Commit messages: - Merge branch 'master' into JDK-8281003 - Merge branch 'master' into JDK-8281003 - removed commented out code - Moved null caller MethodHandles.lookup() test to a more reasonable location - JDK-8