On 21/03/2013 22:12, Brad Wetmore wrote:
:
The codereview is here:
http://cr.openjdk.java.net/~wetmore/8009517/webrev.00/
I plan to push through the deploy gate, as they have an integration
next week. Thomas Ng will do the push for us.
Any objections, please speak now.
No objection
Brad,
I do not build using the old build anymore. This is clearly a blocker
for your work. If you want to suppress the warnings for
overrides/deprecation, then please push the change ( your patch ). We
can revisit this in the future, when it is necessary.
-Chris.
On 03/19/2013 01:29 AM,
I have a suggestion for how to at least partly enable -Werror in the new
build. The penalty is slightly longer compile time, but the difference
should be negligible.
We split the big java compilation in jdk in two. The first pass with
-Werror and all warnings turned on, the second without. We
I tried implementing a PoC for this. Without sjavac, it works, except
that the first pass must be run without -Werror and the second with.
Since we use -implicit:none, this is fine.
With sjavac I had to let it compile the full set of classes first and
then run a second time (into a different
Thank you for trying this Erik.
I did think of this workaround myself, but felt if might not be
acceptable due to the performance penalty. But this information is great
to have.
I wonder if we should try to get all alternatives/proposals on the
table, then make a decision. I know of two
I agree about warning creeping problems. This is a temporary solution,
we should soon be fixing the underlying hashcode/equals problems...but...
Your temporary solution, -overrides, is just that. It will enable the
old build to complete today, but it could fail at any point in the
future, as
On 03/09/2013 12:11 AM, Chris Hegarty wrote:
Everyone seems to agree, a solution needs to be found to allow us to
keep certain areas warning free. This issue is too important, and too
much time was spent, to allow it to regress to the state it was in a
few years ago.
It is true that
On 9 Mar 2013, at 19:01, Jonathan Gibbons jonathan.gibb...@oracle.com wrote:
On 03/09/2013 12:11 AM, Chris Hegarty wrote:
Everyone seems to agree, a solution needs to be found to allow us to keep
certain areas warning free. This issue is too important, and too much time
was spent, to
Looks fine to me. Do we have an issue open for restoring warnings to the new
build?
Mike
On Mar 8 2013, at 05:24 , Chris Hegarty wrote:
Since the new build does not enable -Werror when compiling any java code, and
disables quite a few lint options, new changes my inadvertently introduce
On 03/08/2013 08:40 AM, Jonathan Gibbons wrote:
On 03/08/2013 08:09 AM, Mike Duigou wrote:
On Mar 8 2013, at 07:56 , Alan Bateman wrote:
On 08/03/2013 15:49, Mike Duigou wrote:
Looks fine to me. Do we have an issue open for restoring warnings
to the new build?
Mike
I don't know if there
I responded in another thread (wasn't aware of this one, sorry), there
is an alternate to completely disabling -Werror.
On 3/8/2013 7:58 AM, Chris Hegarty wrote:
On 08/03/2013 15:49, Mike Duigou wrote:
Looks fine to me.
Thanks Mike.
Do we have an issue open for restoring warnings to
11 matches
Mail list logo
