Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Mandy Chung
> On Nov 2, 2015, at 2:28 AM, Jaroslav Bachorik > wrote: > >>> Currently, the 'jdk.management' module is not a part of the JRE image >>> even though it should be. This patch adds 'jdk.management' to >>> PROVIDER_MODULES where it belongs. >> jdk.management exports an API so I assume it should be

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Erik Joelsson
Looks good to me. /Erik On 2015-11-02 11:28, Jaroslav Bachorik wrote: On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Alan Bateman
On 02/11/2015 10:28, Jaroslav Bachorik wrote: On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webre

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management' module is n

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Alan Bateman
On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management' module is not a part of the JRE image even though i

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Alan Bateman
On 02/11/2015 08:34, Jaroslav Bachorik wrote: On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webre

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management' module is n

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Erik Joelsson
The change looks good to me, but I think someone else from the jigsaw team should review this as well. /Erik On 2015-11-02 09:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jba

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Dmitry Samersoff
Jaroslav, Looks good for me (not a reviewer). -Dmitry On 2015-11-02 11:08, Jaroslav Bachorik wrote: > Please, review the following build change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 > Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 > > Currently, the 'jd

RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management' module is not a part of the JRE image even though it should be. This patch adds 'jdk.management' to