Great, that's good then.
Valerie
On 6/22/2018 5:40 PM, Weijun Wang wrote:
On Jun 23, 2018, at 8:35 AM, Valerie Peng wrote:
On 6/22/2018 3:23 PM, Weijun Wang wrote:
On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote:
Max,
Good catch on the SunRsaSign provider bug.
Looking at the changes,
> On Jun 23, 2018, at 8:35 AM, Valerie Peng wrote:
>
> On 6/22/2018 3:23 PM, Weijun Wang wrote:
>>> On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote:
>>>
>>> Max,
>>>
>>> Good catch on the SunRsaSign provider bug.
>>>
>>> Looking at the changes, I think we may have to fine-grain the check o
On 6/22/2018 3:23 PM, Weijun Wang wrote:
On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote:
Max,
Good catch on the SunRsaSign provider bug.
Looking at the changes, I think we may have to fine-grain the check on the
ensureInit() call, i.e.
use ensureInit(boolean sign) instead of ensureInit(
> On Jun 23, 2018, at 2:30 AM, Valerie Peng wrote:
>
> Max,
>
> Good catch on the SunRsaSign provider bug.
>
> Looking at the changes, I think we may have to fine-grain the check on the
> ensureInit() call, i.e.
>
> use ensureInit(boolean sign) instead of ensureInit(), as the current metho
Max,
Good catch on the SunRsaSign provider bug.
Looking at the changes, I think we may have to fine-grain the check on
the ensureInit() call, i.e.
use ensureInit(boolean sign) instead of ensureInit(), as the current
method only ensures that at least one of the privKey, pubKey or
fallbackSig
Looks fine to me.
Thanks,
Xuelei
On 6/21/2018 10:39 PM, Weijun Wang wrote:
Webrev updated at
http://cr.openjdk.java.net/~weijun/8205445/webrev.01
I think I found a bug in SunRsaSign of the RSASSA-PSS signature. Fixed and
added a test.
BTW, I commented out the debug code in security.cpp.
Webrev updated at
http://cr.openjdk.java.net/~weijun/8205445/webrev.01
I think I found a bug in SunRsaSign of the RSASSA-PSS signature. Fixed and
added a test.
BTW, I commented out the debug code in security.cpp. Once there is a bug I can
use it.
Thanks
Max
> On Jun 21, 2018, at 11:23 PM,
Build change looks good.
/Erik
On 2018-06-21 04:12, Weijun Wang wrote:
Please take a review on this change
http://cr.openjdk.java.net/~weijun/8205445/webrev.00/
and the release note at
https://bugs.openjdk.java.net/browse/JDK-8205471
The code change adds RSASSA-PSS signature sup
> On Jun 21, 2018, at 11:07 PM, Xuelei Fan wrote:
>
> Hi Weijun,
>
> The release note and the following notes look reasonable to me.
>
> For the implementation part, could it be a little bit more straightforward if
> wrapping the new attributes (pss/pssParams/fallbackSignature) and codes (i
Hi Weijun,
The release note and the following notes look reasonable to me.
For the implementation part, could it be a little bit more
straightforward if wrapping the new attributes
(pss/pssParams/fallbackSignature) and codes (if pss/fallbackSignature,
etc) in the PSS subclass?
Did you want
Please take a review on this change
http://cr.openjdk.java.net/~weijun/8205445/webrev.00/
and the release note at
https://bugs.openjdk.java.net/browse/JDK-8205471
The code change adds RSASSA-PSS signature support to the SunMSCAPI provider.
Several notes:
1. CryptoAPI (which SunMSCAPI i
11 matches
Mail list logo
