Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-24 Thread Kurt Miller
The BSD's also always define _LITTLE_ENDIAN. Typically something like this: #define _LITTLE_ENDIAN 1234/* LSB first: i386, vax */ #define _BIG_ENDIAN 4321/* MSB first: 68000, ibm, net */ #define _PDP_ENDIAN 3412/* LSB first in word, MSW first in long */ #define _BYTE_ORDER

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Mario Torre
Il 23/06/2009 23:51, Roman Kennke ha scritto: Hi, Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 ref

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Mario Torre
Il 23/06/2009 23:37, Phil Race ha scritto: Ah, everyone must be looking at the old (1.16) lcms that we replaced quite a few builds ago. It didn't have the #if macintosh Whoops... I admit that we depend on a slightly older OpenJDK version, and this time I didn't checked the latest code :) I ju

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Roman Kennke
Hi, Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 references to this _LITTLE_ENDIAN name Sun would n

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Roman Kennke
Hi, first of all, I think this is a LCMS problem, so we should think about how to fix this _upstream_, otherwise we end up maintaining a patched version of lcms *shudder*. Then I don't think it's a good idea to depend on such 'internal' defines. One OS defines or not _LITTLE_ENDIAN, others (

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Kelly O'Hair
Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 references to this _LITTLE_ENDIAN name Sun would need to

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Phil Race
Roman Kennke wrote: Hi, first of all, I think this is a LCMS problem, so we should think about how to fix this _upstream_, otherwise we end up maintaining a patched version of lcms *shudder*. But I see only that in the lcms.h file. And it is protected inside #if macintosh so I can't believ