Re: Adding asm to JDK 8

2012-02-13 Thread Brian Goetz
Lambda was the proximate driving force. EE was also a contributor; as I mentioned earlier, Glassfish includes half a dozen versions of ASM, some of different vintages, because of how it is componentized. We can probably get rid of the extra repo once we can make it into a module. On 2/3/201

Re: Adding asm to JDK 8

2012-02-06 Thread Kelly O'Hair
On Feb 6, 2012, at 8:46 AM, Jim Holmlund wrote: > > > On 2/6/2012 12:04 AM, David Holmes wrote: >> On 4/02/2012 5:03 AM, Jim Holmlund wrote: >>> On 2/2/2012 7:13 PM, David Holmes wrote: I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up s

Re: Adding asm to JDK 8

2012-02-06 Thread Jim Holmlund
On 2/6/2012 12:04 AM, David Holmes wrote: On 4/02/2012 5:03 AM, Jim Holmlund wrote: On 2/2/2012 7:13 PM, David Holmes wrote: I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cr

Re: Adding asm to JDK 8

2012-02-06 Thread David Holmes
On 4/02/2012 5:03 AM, Jim Holmlund wrote: On 2/2/2012 7:13 PM, David Holmes wrote: I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cross-compilation issues with building this? I'

Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/3/2012 9:11 AM, Phil Race wrote: Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. Sorry about that. I thought I was jut

Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/2/2012 9:08 PM, Dmitry Samersoff wrote: Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm I don't plan to remove that myself, but jaxws will be notified and urged to remove their version. Do you have permis

Re: Adding asm to JDK 8

2012-02-03 Thread Jim Holmlund
On 2/2/2012 7:13 PM, David Holmes wrote: Hi Jim, I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cross-compilation issues with building this? I'm assuming not but want to ch

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The official ASM distro has six JARs: core: processing classes based on Class{Reader,Writer} visitors tree: alternate API for processing classes; used in more advanced applications util: debugging utilities, such as the checking and tracing visitors commons: random contributions, some of wh

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
On 2/3/2012 9:38 AM, Brian Goetz wrote: Lambda was the proximate driving force. EE was also a contributor; as I mentioned earlier, Glassfish includes half a dozen versions of ASM, some of different vintages, because of how it is componentized. We can probably get rid of the extra repo once we

Re: Adding asm to JDK 8

2012-02-03 Thread Dmitry Samersoff
Brian, Does any body has a justification to include all of them. ASM has core and couple of interfaces around it. Subset included now to jaxp workspace is enough to do all necessary things. -Dmitry On 2012-02-03 07:34, Brian Goetz wrote: > The main ASM distribution is broken into 5 jars, based

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. But does it really need its own new repo ? I think there needs to be a discuss

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The hope there is that JAX-WS can convert over to / certify on the bundled ASM, and then we can get rid of their old copy. Same process as removing APT; they have to do some work first. On 2/3/2012 6:48 AM, Alan Bateman wrote: On 03/02/2012 05:08, Dmitry Samersoff wrote: Jim, Do you plan to

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. On 2/2/2012 10:33 PM, Mandy Chung wrote: On 2/2/2012 7:13 PM, David Holmes wrote: Okay two questions :) : do you know when this will get modul

Re: Adding asm to JDK 8

2012-02-03 Thread Brian Goetz
The current plan is to use ASM long-term to generate classes at runtime. Now, it is possible that "something better will come along" (perhaps needed functionality will be provided by JSR-292 in the future) but we're not banking on this. The EE team has also asked that we officially include AS

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 15:07, Brian Goetz wrote: The current plan is to use ASM long-term to generate classes at runtime. Now, it is possible that "something better will come along" (perhaps needed functionality will be provided by JSR-292 in the future) but we're not banking on this. The EE team has

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 05:08, Dmitry Samersoff wrote: Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm Do you have permission to include one particular version or plan to sync it regularly? -Dmitry This is a good point. On

Re: Adding asm to JDK 8

2012-02-03 Thread Alan Bateman
On 03/02/2012 04:04, Mandy Chung wrote: Great. That would give a good starting point. Mandy On 2/2/2012 7:34 PM, Brian Goetz wrote: The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. Brian - I

Re: Adding asm to JDK 8

2012-02-02 Thread Dmitry Samersoff
Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm Do you have permission to include one particular version or plan to sync it regularly? -Dmitry On 2012-02-03 07:13, David Holmes wrote: Hi Jim, I added build-dev t

Re: Adding asm to JDK 8

2012-02-02 Thread David Holmes
On 3/02/2012 1:34 PM, Brian Goetz wrote: The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. That will be an interesting testcase for jigsaw as well I think. David On 2/2/2012 10:33 PM, Mandy C

Re: Adding asm to JDK 8

2012-02-02 Thread Mandy Chung
Great. That would give a good starting point. Mandy On 2/2/2012 7:34 PM, Brian Goetz wrote: The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. On 2/2/2012 10:33 PM, Mandy Chung wrote: On 2/2

Re: Adding asm to JDK 8

2012-02-02 Thread Mandy Chung
On 2/2/2012 7:13 PM, David Holmes wrote: Okay two questions :) : do you know when this will get modularized and show up in the jigsaw repositories? FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and hope to do it in a regular basis. It's currently sync'ed with jdk8-b2

Re: Adding asm to JDK 8

2012-02-02 Thread David Holmes
Hi Jim, I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cross-compilation issues with building this? I'm assuming not but want to check. Okay two questions :) : do you know w