Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
P.S. Forgot to mention, this looks good to me. Thanks for jumping in on this one. ;) Brad On 1/9/2014 12:07 AM, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & si

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Bradford Wetmore
On 1/9/2014 12:34 AM, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_V

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread mark . reinhold
2014/1/8 16:47 -0800, erik.joels...@oracle.com: > ... > > For the future, is there a reason for not automatically generating the > "specification-version" based on the version numbers we have, or at > least move the definition of it to the version numbers file? Excellent question. We should tr

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Erik Joelsson
On 2014-01-09 09:34, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & signing of crypto signed jar files. Being from the secur

Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8

2014-01-09 Thread Alan Bateman
On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build & signing of crypto signed jar files. Being from the security side and not the build side of the op