Re: Fix zero build on arm

2013-04-29 Thread Omair Majid
On 04/29/2013 12:09 PM, Mike Duigou wrote: > Done. JDK-8013480 created Thanks! I have pushed the changesets: http://hg.openjdk.java.net/jdk8/build/rev/1dfcc874461e http://hg.openjdk.java.net/jdk8/build/jdk/rev/12af7c32c648 > and assigned to you. I cant access https://jbs.oracle.com/bugs/browse/

Re: Fix zero build on arm

2013-04-29 Thread Mike Duigou
Done. JDK-8013480 created and assigned to you. Mike On Apr 29 2013, at 08:56 , Omair Majid wrote: > On 04/29/2013 05:35 AM, Erik Joelsson wrote: >> Looks good! > > Thanks for the review! Could I get a bug id so I can push this to > jdk8/build? > > Thanks, > Omair > > -- > PGP Key: 66484681 (

Re: Fix zero build on arm

2013-04-29 Thread Omair Majid
On 04/29/2013 05:35 AM, Erik Joelsson wrote: > Looks good! Thanks for the review! Could I get a bug id so I can push this to jdk8/build? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

Re: Fix zero build on arm

2013-04-29 Thread Erik Joelsson
Looks good! /Erik On 2013-04-22 19:58, Omair Majid wrote: Hi Erik, On 04/17/2013 03:31 AM, Erik Joelsson wrote: On 2013-04-17 04:05, Omair Majid wrote: The following webrev makes zero build succesfully on arm: http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/ The only problem I ran

Re: Fix zero build on arm

2013-04-22 Thread Omair Majid
Hi Erik, On 04/17/2013 03:31 AM, Erik Joelsson wrote: > On 2013-04-17 04:05, Omair Majid wrote: >> The following webrev makes zero build succesfully on arm: >> http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/ >> >> The only problem I ran into while trying to build zero on armv7l is that

Re: Fix zero build on arm

2013-04-17 Thread Erik Joelsson
On 2013-04-17 15:56, Andrew Hughes wrote: Where are you getting this line numbers from? I don't see any. I just realized not all the diffs have them. I usually start with "Sdiffs" and it shows line numbers. The "New" and "Old" also has them. /Erik

Re: Fix zero build on arm

2013-04-17 Thread Andrew Hughes
- Original Message - > > > On 2013-04-17 04:05, Omair Majid wrote: > > Hi, > > > > The following webrev makes zero build succesfully on arm: > > http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/ > > > > The only problem I ran into while trying to build zero on armv7l is that > >

Re: Fix zero build on arm

2013-04-17 Thread Erik Joelsson
On 2013-04-17 04:05, Omair Majid wrote: Hi, The following webrev makes zero build succesfully on arm: http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/ The only problem I ran into while trying to build zero on armv7l is that the gcc there does not like -m32. The changes make the buil