Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
On 22/03/2012 12:30 PM, Daniel D. Daugherty wrote: That would be this: Changeset: fb3a2cafc230 Author: andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 Thanks Dan! I see it came in through the build repo which is why I couldn't find it. Now I

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread Daniel D. Daugherty
That would be this: Changeset: fb3a2cafc230 Author:andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholm

Re: Patch to fix build breakage with GCC 4.7

2012-03-21 Thread David Holmes
Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughes [2012-03-02 10:09]: - Original Message - * Andrew Hughes [2012-03-01 15:40]: - Original Message - * Kelly O'Hair [2012-02-29 20:39]: The sample.makefile.txt files may not even

Re: Patch to fix build breakage with GCC 4.7

2012-03-08 Thread Deepak Bhole
* Andrew Hughes [2012-03-08 09:06]: > - Original Message - > > * Andrew Hughes [2012-03-02 10:09]: > > > - Original Message - > > > > * Andrew Hughes [2012-03-01 15:40]: > > > > > - Original Message - > > > > > > * Kelly O'Hair [2012-02-29 20:39]: > > > > > > > The sampl

Re: Patch to fix build breakage with GCC 4.7

2012-03-08 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2012-03-02 10:09]: > > - Original Message - > > > * Andrew Hughes [2012-03-01 15:40]: > > > > - Original Message - > > > > > * Kelly O'Hair [2012-02-29 20:39]: > > > > > > The sample.makefile.txt files may not even be used during >

Re: Patch to fix build breakage with GCC 4.7

2012-03-02 Thread Deepak Bhole
* Andrew Hughes [2012-03-02 10:09]: > - Original Message - > > * Andrew Hughes [2012-03-01 15:40]: > > > - Original Message - > > > > * Kelly O'Hair [2012-02-29 20:39]: > > > > > The sample.makefile.txt files may not even be used during the > > > > > build, I'm not sure. > > > >

Re: Patch to fix build breakage with GCC 4.7

2012-03-02 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2012-03-01 15:40]: > > - Original Message - > > > * Kelly O'Hair [2012-02-29 20:39]: > > > > The sample.makefile.txt files may not even be used during the > > > > build, I'm not sure. > > > > They may have only been supplied as documentation

Re: Patch to fix build breakage with GCC 4.7

2012-03-01 Thread David Holmes
BugId: 7150392 Linux build breaks with GCC 4.7 due to unrecognized option David - On 2/03/2012 7:14 AM, Deepak Bhole wrote: * Andrew Hughes [2012-03-01 15:40]: - Original Message - * Kelly O'Hair [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the

Re: Patch to fix build breakage with GCC 4.7

2012-03-01 Thread Deepak Bhole
* Andrew Hughes [2012-03-01 15:40]: > - Original Message - > > * Kelly O'Hair [2012-02-29 20:39]: > > > The sample.makefile.txt files may not even be used during the > > > build, I'm not sure. > > > They may have only been supplied as documentation on how to build > > > the native code. >

Re: Patch to fix build breakage with GCC 4.7

2012-03-01 Thread Andrew Hughes
- Original Message - > * Kelly O'Hair [2012-02-29 20:39]: > > The sample.makefile.txt files may not even be used during the > > build, I'm not sure. > > They may have only been supplied as documentation on how to build > > the native code. > > > > Deleting the -mimpure-text is probably ri

Re: Patch to fix build breakage with GCC 4.7

2012-03-01 Thread Deepak Bhole
* Kelly O'Hair [2012-02-29 20:39]: > The sample.makefile.txt files may not even be used during the build, I'm not > sure. > They may have only been supplied as documentation on how to build the native > code. > > Deleting the -mimpure-text is probably right all around. > Okay, so then looks l

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread Kelly O'Hair
The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. -kto On Feb 29, 2012, at 4:04 PM, Deepak Bhole wrote: > * David Holmes

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread Deepak Bhole
* David Holmes [2012-02-29 18:48]: > Sorry let me back up a step here. The issue with linux-sparc > involved the actual build instructions in Compiler-gcc.gmk, not so > much the sample makefiles for the various JVMTI demos - at least in > my response. Unless someone from serviceability indicates o

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread Deepak Bhole
* David Holmes [2012-02-29 18:49]: > On 1/03/2012 9:43 AM, Deepak Bhole wrote: > >* David Holmes [2012-02-29 18:29]: > >>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ > >> > >>Where is ARCH_FAMILY being set? > >> > > > >It is set in make/common/shared/Platform.gmk > > But that has no conn

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread David Holmes
On 1/03/2012 9:43 AM, Deepak Bhole wrote: * David Holmes [2012-02-29 18:29]: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? It is set in make/common/shared/Platform.gmk But that has no connection to the sample Makefiles. David Deepak David If

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread David Holmes
Sorry let me back up a step here. The issue with linux-sparc involved the actual build instructions in Compiler-gcc.gmk, not so much the sample makefiles for the various JVMTI demos - at least in my response. Unless someone from serviceability indicates otherwise I'd suggest just deleting -mimp

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread Deepak Bhole
* David Holmes [2012-02-29 18:29]: > Hi Deepak, > > On 1/03/2012 6:30 AM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 21:50]: > >>On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >>>* David Holmes [2012-01-30 19:57]: > While gcc compilation on sparc is rare I'm not sure that simply > >>

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread David Holmes
Hi Deepak, On 1/03/2012 6:30 AM, Deepak Bhole wrote: * David Holmes [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmes [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right

Re: Patch to fix build breakage with GCC 4.7

2012-02-29 Thread Deepak Bhole
* David Holmes [2012-01-30 21:50]: > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 19:57]: > >>While gcc compilation on sparc is rare I'm not sure that simply > >>deleting the sparc-only option unconditionally is the right thing to > >>do. > >> > > > >I thought about t

Re: Patch to fix build breakage with GCC 4.7

2012-02-03 Thread Deepak Bhole
* David Holmes [2012-01-30 21:50]: > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 19:57]: > >>While gcc compilation on sparc is rare I'm not sure that simply > >>deleting the sparc-only option unconditionally is the right thing to > >>do. > >> > > > >I thought about t

Re: Patch to fix build breakage with GCC 4.7

2012-02-03 Thread Deepak Bhole
* David Holmes [2012-01-30 19:57]: > Hi Deepak, > > The primary change here is a build change so I've cc'ed build-dev. > > The majority of the changes are to JVMTI demo files hence I've cc'd > serviceability-dev. > > I think JDK8-dev doesn't need to be included now so I've bcc'd it. > > While

Re: Patch to fix build breakage with GCC 4.7

2012-02-01 Thread Paul Hohensee
On, and it's not supported by Oracle, of course. One of the Linux distro companies might be interested though. On 2/1/12 7:12 AM, Paul Hohensee wrote: linux-sparc used to build and run fine (I did the port way back when), so it should be relatively easy to resurrect. The original port was on a

Re: Patch to fix build breakage with GCC 4.7

2012-02-01 Thread Paul Hohensee
linux-sparc used to build and run fine (I did the port way back when), so it should be relatively easy to resurrect. The original port was on a T1. Paul On 1/31/12 10:23 AM, Deepak Bhole wrote: * David Holmes [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmes [

Re: Patch to fix build breakage with GCC 4.7

2012-01-31 Thread Andrew Hughes
- Original Message - > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > > * David Holmes [2012-01-30 19:57]: > >> While gcc compilation on sparc is rare I'm not sure that simply > >> deleting the sparc-only option unconditionally is the right thing > >> to > >> do. > >> > > > > I thought ab

Re: Patch to fix build breakage with GCC 4.7

2012-01-30 Thread David Holmes
On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmes [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC +

Re: Patch to fix build breakage with GCC 4.7

2012-01-30 Thread Kelly O'Hair
This change looks fine to me. It would be ok with me for this change to be pushed into the jdk8/build forest. Once there, I can do a JPRT run to verify it, but I really don't seen any issue here. -kto On Jan 30, 2012, at 4:57 PM, David Holmes wrote: > Hi Deepak, > > The primary change here is

Re: Patch to fix build breakage with GCC 4.7

2012-01-30 Thread David Holmes
Hi Deepak, The primary change here is a build change so I've cc'ed build-dev. The majority of the changes are to JVMTI demo files hence I've cc'd serviceability-dev. I think JDK8-dev doesn't need to be included now so I've bcc'd it. While gcc compilation on sparc is rare I'm not sure that si