Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2018-02-20 Thread Erik Joelsson
This looks ok, I will push it. https://bugs.openjdk.java.net/browse/JDK-8198425 /Erik On 2018-02-19 04:39, Steve Groeger wrote: diff -r b2f2bdba0472 make/Main.gmk --- a/make/Main.gmkFri Jan 26 11:27:53 2018 -0800 +++ b/make/Main.gmkMon Feb 19 12:31:55 2018 + @@ -644,8 +644,11 @@    genera

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2018-02-19 Thread Steve Groeger
19:19 Subject: Re: Proposal: make/Main.gmk Add extra extension/override points to the make file Hello, I would rename the JVM_VARIANT_TARGETS to JVM_MAIN_LIB_TARGETS. The purpose of this target is to be the minimal amount of prerequisites before we can start linking to -ljvm. I would also mov

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2018-02-16 Thread Erik Joelsson
Hello, I would rename the JVM_VARIANT_TARGETS to JVM_MAIN_LIB_TARGETS. The purpose of this target is to be the minimal amount of prerequisites before we can start linking to -ljvm. I would also move the definition of that variable down to its first use, like the other variables. I'm not clea

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2017-12-14 Thread Steve Groeger
England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -Erik Joelsson wrote: - To: Steve Groeger , build-dev@openjdk.java.net From: Erik Joelsson Date: 12/14/2017 10:59 Subject: Re: Proposal: make/Main.gmk Add extra extension/override

Re: Proposal: make/Main.gmk Add extra extension/override points to the make file

2017-12-14 Thread Erik Joelsson
Hello Steve, It's certainly an interesting test of the existing extension points when someone else needs to use them. The use case of replacing hotspot completely is definitely new to me. First of all, Main.gmk only contains one call to IncludeCustomExtension close to the beginning of the fi