Re: RFR(S): 8214343: Handle the absence of Xrandr more generically

2018-11-27 Thread Phil Race
+1 -phil. On 11/27/18 8:45 AM, Erik Joelsson wrote: Looks ok to me. /Erik On 2018-11-27 05:52, Volker Simonis wrote: Hi, can I please have a review for the following trivial change which handles the absence of Xrandr more generically: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214

Re: RFR(S): 8214343: Handle the absence of Xrandr more generically

2018-11-27 Thread Erik Joelsson
Looks ok to me. /Erik On 2018-11-27 05:52, Volker Simonis wrote: Hi, can I please have a review for the following trivial change which handles the absence of Xrandr more generically: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214343/ https://bugs.openjdk.java.net/browse/JDK-8214343 Ch

Re: RFR(S): 8214343: Handle the absence of Xrandr more generically

2018-11-27 Thread Thomas Stüfe
Looks good Volker. I agree, NO_XRANDR is reasonable and better than HAVE_XRANDR. I have to say, the amount of work this took is insane for the size of the problem involved. Cheers, Thomas On Tue, Nov 27, 2018 at 2:54 PM Volker Simonis wrote: > > Hi, > > can I please have a review for the follow