Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-16 Thread Coleen Phillimore
On Mon, 9 Nov 2020 20:39:40 GMT, Coleen Phillimore wrote: >> Thanks @sspitsyn . I'm going to leave the gc_notification code because >> structurally the two sides of the if statement are different and it's not a >> long function. Thank you for reviewing the change. > > This change also passes

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-09 Thread Coleen Phillimore
On Thu, 5 Nov 2020 12:42:40 GMT, Coleen Phillimore wrote: >> Thank you for the update, Coleen! >> I leave it for you to decide to refactor the gc_notification or not. >> Thanks, >> Serguei > > Thanks @sspitsyn . I'm going to leave the gc_notification code because > structurally the two sides of

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-05 Thread Coleen Phillimore
On Wed, 4 Nov 2020 22:09:21 GMT, Serguei Spitsyn wrote: >> Coleen Phillimore has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add back WeakProcessorPhases::Phase enum. >> - Serguei 1. > > Thank you for the update, Coleen! > I leave it

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-04 Thread Serguei Spitsyn
On Wed, 4 Nov 2020 12:21:12 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >> ta

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-04 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table poin