On Fri, 2020-04-17 at 07:32 -0700, Erik Joelsson wrote:
> This version looks good to me.
Thanks for the review, Erik!
Cheers,
Severin
> /Erik
>
> On 2020-04-17 05:15, Severin Gehwolf wrote:
> > Hi Magnus,
> >
> > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> > > On 2020-04-17
This version looks good to me.
/Erik
On 2020-04-17 05:15, Severin Gehwolf wrote:
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, l
On Fri, 2020-04-17 at 14:28 +0200, Magnus Ihse Bursie wrote:
> On 2020-04-17 14:15, Severin Gehwolf wrote:
> > Hi Magnus,
> >
> > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> > > On 2020-04-17 12:18, Severin Gehwolf wrote:
> > > > Hi,
> > > >
> > > > Could I please get a review
On 2020-04-17 14:15, Severin Gehwolf wrote:
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, like 'foo, bar, Inc.' the build fails. A
Hi Magnus,
On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote:
> On 2020-04-17 12:18, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this build fix? When --with-vendor-name
> > contains a comma, like 'foo, bar, Inc.' the build fails. As it turns
> > out SetupBuildL
On 2020-04-17 12:18, Severin Gehwolf wrote:
Hi,
Could I please get a review of this build fix? When --with-vendor-name
contains a comma, like 'foo, bar, Inc.' the build fails. As it turns
out SetupBuildLauncherBody calls SetupJdkExecutable with some
parameters. If $(VERSION_CFLAGS) contain a com
