On Thu, 22 Apr 2021 06:10:17 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 11 additional commits
>> since
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Fri, 23 Apr 2021 01:23:56 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Thu, 22 Apr 2021 06:19:29 GMT, Ioi Lam wrote:
>> I don't suppose we can just exclude the new directory rather than listing
>> individual files?
>
> Fixed. Now all files under share/cds are excluded. I needed to move
> compactHashtable.cpp back to its old location since a little of it is used
On Thu, 22 Apr 2021 06:27:45 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
On Thu, 22 Apr 2021 06:27:45 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
On Thu, 22 Apr 2021 06:19:19 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/dynamicArchive.hpp line 38:
>>
>>> 36: #include "utilities/resourceHash.hpp"
>>> 37:
>>> 38: #if INCLUDE_CDS
>>
>> I have to wonder who is including this file and why, if CDS is not enabled.
>
> E.g., jvm.cpp includes dy
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Thu, 22 Apr 2021 04:16:57 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - exclude all files under shared/cds if CDS is disabled;
>> compactHashtable.cpp cannot be excluded since a bit of it is us
On Thu, 22 Apr 2021 04:14:38 GMT, David Holmes wrote:
>> Thank you!
>
> I don't suppose we can just exclude the new directory rather than listing
> individual files?
Fixed. Now all files under share/cds are excluded. I needed to move
compactHashtable.cpp back to its old location since a little
On Thu, 22 Apr 2021 06:10:17 GMT, Thomas Stuefe wrote:
> Hi @iklam,
>
> this is a very welcome change!
>
> Nothing much to add to what David wrote (include guards need renaming).
>
> Apart from that, I was surprised that no gtests needed to be adapted, but
> seems cds has no gtests?
>
> I te
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classf
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 23:05:26 GMT, Erik Joelsson wrote:
>> make/hotspot/lib/JvmFeatures.gmk line 134:
>>
>>> 132: metaspaceShared_$(HOTSPOT_TARGET_CPU_ARCH).cpp \
>>> 133: sharedClassUtil.cpp \
>>> 134: sharedPathsMiscInfo.cpp \
>>
>> Removed obsolete files that no longer exist
On Wed, 21 Apr 2021 22:04:13 GMT, Ioi Lam wrote:
>> The number of CDS source files have grown significantly. To improve
>> modularity, the following files should be moved a new directory,
>> src/hotspot/share/cds.
>>
>> - src/hotspot/share/classfile/classListParser.cpp
>> - src/hotspot/share/c
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
On Wed, 21 Apr 2021 21:55:25 GMT, Ioi Lam wrote:
> The number of CDS source files have grown significantly. To improve
> modularity, the following files should be moved a new directory,
> src/hotspot/share/cds.
>
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfi
20 matches
Mail list logo
