Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-30 Thread Chris Hegarty
On 30/01/17 08:08, Magnus Ihse Bursie wrote: On 2017-01-26 15:28, Chris Hegarty wrote: I’m not sure of the latest status of warnings in the build, but just to say, libstcp was always built with 0 warnings being emitted ( the JNI code has unused this/class parameters that cannot be removed ). If

Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-30 Thread Magnus Ihse Bursie
On 2017-01-26 15:28, Chris Hegarty wrote: I’m not sure of the latest status of warnings in the build, but just to say, libstcp was always built with 0 warnings being emitted ( the JNI code has unused this/class parameters that cannot be removed ). If you remove this suppression won’t the compilat

Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-26 Thread Chris Hegarty
I’m not sure of the latest status of warnings in the build, but just to say, libstcp was always built with 0 warnings being emitted ( the JNI code has unused this/class parameters that cannot be removed ). If you remove this suppression won’t the compilation of code from libsctp now produce a warn

Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-26 Thread Erik Joelsson
Looks good. /Erik On 2017-01-26 14:54, Magnus Ihse Bursie wrote: When fixing JDK-8081616 , it turned out that DISABLED_WARNINGS_gcc := unused-parameter seemed to be needed for libsctp in make/lib/Lib-jdk.sctp.gmk. This is not be needed anymor