Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread Gary Adams
On 12/14/15 07:34, David Holmes wrote: On 14/12/2015 6:30 PM, Magnus Ihse Bursie wrote: On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-inf

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread David Holmes
On 14/12/2015 6:30 PM, Magnus Ihse Bursie wrote: On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no majo

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread Erik Joelsson
Looks good to me. /Erik On 2015-12-11 23:24, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread Magnus Ihse Bursie
On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this p

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-14 Thread David Holmes
Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspo

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-11 Thread Magnus Ihse Bursie
On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspot/make/lib/Lib-jdk.hotspot.agent.gmk though.) It seems I

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-12-11 Thread Magnus Ihse Bursie
Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspot/make/lib/Lib-jdk.hotspot.agent.gmk though.) On 2015-11-16 05:33, David Holmes wrote: Hi Magnus, I ha

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-16 Thread Erik Joelsson
On 2015-11-16 05:33, David Holmes wrote: Hi Magnus, I had a flick through most of the files. Overall seems okay but I have a few queries below. On 13/11/2015 12:43 PM, Magnus Ihse Bursie wrote: The build-infra project has collected a number of minor fixes and changes during the new hotspot

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-15 Thread David Holmes
Hi Magnus, I had a flick through most of the files. Overall seems okay but I have a few queries below. On 13/11/2015 12:43 PM, Magnus Ihse Bursie wrote: The build-infra project has collected a number of minor fixes and changes during the new hotspot build development. It's a mix of code clean

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-13 Thread Magnus Ihse Bursie
On 2015-11-13 12:07, Magnus Ihse Bursie wrote: It turned out I was a bit to quick to send out this review request. There were a couple of issues I didn't spot earlier. The new -h flag on solaris prompted the linker to complain when we tried to set a soname on an executable. We've done this for

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-13 Thread Magnus Ihse Bursie
It turned out I was a bit to quick to send out this review request. There were a couple of issues I didn't spot earlier. The new -h flag on solaris prompted the linker to complain when we tried to set a soname on an executable. We've done this for other toolchains before but they have just sile

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-13 Thread Erik Joelsson
Looks good. /Erik On 2015-11-13 03:43, Magnus Ihse Bursie wrote: The build-infra project has collected a number of minor fixes and changes during the new hotspot build development. It's a mix of code cleanup and new capabilities. Not all of these new features are immediately beneficial to th