Re: RFR: JDK-8144039: Enable javac server by default

2015-11-27 Thread Erik Joelsson
Hello, On 2015-11-27 02:21, David Holmes wrote: Hi Erik, On 26/11/2015 6:17 PM, Erik Joelsson wrote: Hello, This is not sjavac, but just the rather new feature javac-server. It takes the client/server model from sjavac and applies it to plain old javac. What this means is that when we invoke

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-26 Thread David Holmes
Hi Erik, On 26/11/2015 6:17 PM, Erik Joelsson wrote: Hello, This is not sjavac, but just the rather new feature javac-server. It takes the client/server model from sjavac and applies it to plain old javac. What this means is that when we invoke javac, it will spawn off a background server proce

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-26 Thread Erik Joelsson
Hello, This is not sjavac, but just the rather new feature javac-server. It takes the client/server model from sjavac and applies it to plain old javac. What this means is that when we invoke javac, it will spawn off a background server process that stays alive for the duration of the build.

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-25 Thread David Holmes
Hi Erik, Magnus, Has this been extensively tested with all our build environments? It's been a while so could you give an overview of exactly how the sjavac thing works. Changes that affect every single person building the JDK should not be rushed through! Thanks, David On 26/11/2015 12:4

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-25 Thread Magnus Ihse Bursie
On 2015-11-25 15:45, Erik Joelsson wrote: Doh, here you go: diff -r 358fb90ae6e6 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -411,9 +411,9 @@ AC_MSG_RESULT([$ENABLE_SJAVAC]) AC_SUBST(ENABLE_SJAVAC) - AC_ARG

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-25 Thread Erik Joelsson
Doh, here you go: diff -r 358fb90ae6e6 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -411,9 +411,9 @@ AC_MSG_RESULT([$ENABLE_SJAVAC]) AC_SUBST(ENABLE_SJAVAC) - AC_ARG_ENABLE([javac-server], [AS_HELP_STRING([--

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-25 Thread Magnus Ihse Bursie
On 2015-11-25 15:11, Erik Joelsson wrote: Hello, The --enable-javac-server feature seems to be working well and is providing considerable speedup when building the JDK. We should make the option enabled by default. As an example, on my local machine, a run of "make exploded-image" without j