Looks good.
/Erik
On 2016-10-26 15:22, Magnus Ihse Bursie wrote:
On 2016-10-26 14:31, Erik Joelsson wrote:
Hello,
Looks good in general.
* The REGEXP parameter is weirdly named. I realize you didn't
introduce this name, but I think we should call it something better
since it's clearly not
On 2016-10-26 14:31, Erik Joelsson wrote:
Hello,
Looks good in general.
* The REGEXP parameter is weirdly named. I realize you didn't
introduce this name, but I think we should call it something better
since it's clearly not a regular expression. PACKAGE_FILTER perhaps?
You're absolutely righ
Hello,
Looks good in general.
* The REGEXP parameter is weirdly named. I realize you didn't introduce
this name, but I think we should call it something better since it's
clearly not a regular expression. PACKAGE_FILTER perhaps?
* Looks like an extra space on line 346.
* Missing space on 75
