Looks good to me.
/Erik
On 2016-12-06 11:15, Magnus Ihse Bursie wrote:
On 2016-12-05 05:34, David Holmes wrote:
Hi Magnus,
Some independent changes are going to collide here. :)
hotspot/make/test/JtregNative.gmk
This change has already happened in hs repo - JDK-8169261.
Ok, I removed th
No further comments on the hotspot changes.
Thanks,
David
On 6/12/2016 8:15 PM, Magnus Ihse Bursie wrote:
On 2016-12-05 05:34, David Holmes wrote:
Hi Magnus,
Some independent changes are going to collide here. :)
hotspot/make/test/JtregNative.gmk
This change has already happened in hs rep
On 2016-12-05 05:34, David Holmes wrote:
Hi Magnus,
Some independent changes are going to collide here. :)
hotspot/make/test/JtregNative.gmk
This change has already happened in hs repo - JDK-8169261.
Ok, I removed that fix from my patch.
---
hotspot/test/Makefile
33 USE_JTREG_VERSION :=
Hi Magnus,
Some independent changes are going to collide here. :)
hotspot/make/test/JtregNative.gmk
This change has already happened in hs repo - JDK-8169261.
---
hotspot/test/Makefile
33 USE_JTREG_VERSION := 4.1
Aside: - Jigsaw bumped this to 4.2 (and I think that was a while ago). I
do
Looks good.
/Erik
On 2016-12-02 10:24, Magnus Ihse Bursie wrote:
There is a lot of common code that has been duplicated in
*/test/Makefile. For jdk, hotspot, jaxp and nashorn, most of the code
in the corresponding files are identical. (The odd-man-out is
langtools which is quite different.)
