Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

On Wed, Feb 7, 2018 at 3:20 PM, Alan Bateman wrote: > > > On 07/02/2018 14:13, Thomas Stüfe wrote: > >> Could this also explain what we see in some of our nightlies? The builds >> broke on some platforms for us (e.g. linux ppcle). It seems that >> "@LIBZ_CFLAGS@" does

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

On 07/02/2018 14:13, Thomas Stüfe wrote: Could this also explain what we see in some of our nightlies? The builds broke on some platforms for us (e.g. linux ppcle). It seems that "@LIBZ_CFLAGS@" does not get expanded correctly and finds its way into the makefile, confusing the compiler: (

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

Could this also explain what we see in some of our nightlies? The builds broke on some platforms for us (e.g. linux ppcle). It seems that "@LIBZ_CFLAGS@" does not get expanded correctly and finds its way into the makefile, confusing the compiler: ( /sapmnt/appl_sw/gcc-4.8/bin/gcc ... -g1 -fPIC

Re: RFR: JDK-8196911: Windows build fails with not finding zlib.h

Erik: A small typo managed to sneak itself into my previous patch, causing the build to fail on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8196911 [...snip...] - if test "x$USER_EXTERNAL_LIBZ" = "xfalse"; then + if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then Looks good. I