Re: RFR: JDK-8199681 Remove boilerplate code from creating native jtreg tests

2018-03-16 Thread David Holmes
On 16/03/2018 9:43 PM, Magnus Ihse Bursie wrote: On 2018-03-16 03:48, David Holmes wrote: Hi Magnus, Removing boilerplate is good but the exclude mechanism seems rather awkward compared to the previous include. It's much more obvious when writing a platform specific native test to include it

Re: RFR: JDK-8199681 Remove boilerplate code from creating native jtreg tests

2018-03-16 Thread Magnus Ihse Bursie
On 2018-03-16 03:48, David Holmes wrote: Hi Magnus, Removing boilerplate is good but the exclude mechanism seems rather awkward compared to the previous include. It's much more obvious when writing a platform specific native test to include it for that platform, rather than exclude it for a

Re: RFR: JDK-8199681 Remove boilerplate code from creating native jtreg tests

2018-03-15 Thread David Holmes
Hi Magnus, Removing boilerplate is good but the exclude mechanism seems rather awkward compared to the previous include. It's much more obvious when writing a platform specific native test to include it for that platform, rather than exclude it for all other platforms. You run the risk of hav

Re: RFR: JDK-8199681 Remove boilerplate code from creating native jtreg tests

2018-03-15 Thread Erik Joelsson
Looks good. /Erik On 2018-03-15 06:01, Magnus Ihse Bursie wrote: There's currently a lot of boilerplate code needed to setup a new native jtreg test. This was never the way it was intended to work -- the idea was that you basically should just add the file and then things should work automat