Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-31 Thread Magnus Ihse Bursie
On 2019-01-30 19:45, Erik Joelsson wrote: Here is a new webrev: http://cr.openjdk.java.net/~erikj/8204564/webrev.02/ Looks good to me! /Magnus /Erik On 2019-01-30 08:52, Erik Joelsson wrote: Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote:

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Erik Joelsson
Here is a new webrev: http://cr.openjdk.java.net/~erikj/8204564/webrev.02/ /Erik On 2019-01-30 08:52, Erik Joelsson wrote: Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and increas

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Erik Joelsson
Hello, On 2019-01-30 01:51, Magnus Ihse Bursie wrote: On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is l

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-30 Thread Magnus Ihse Bursie
On 2019-01-30 02:18, Erik Joelsson wrote: Hello, Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is later used to optimize the JDK image with jlink. The prob

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-29 Thread Tim Bell
Erik: Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is later used to optimize the JDK image with jlink. The problem here is that the tool needs to print some o