LGTM.
/Magnus
> 15 feb. 2019 kl. 23:28 skrev Erik Joelsson :
>
> That would look better. Here is a new webrev:
> http://cr.openjdk.java.net/~erikj/8217032/webrev.03/index.html
>
> /Erik
>
>> On 2019-02-15 14:04, Mikael Vidstedt wrote:
>> How about having the variable be called something like
+1
Cheers,
Mikael
> On Feb 15, 2019, at 2:28 PM, Erik Joelsson wrote:
>
> That would look better. Here is a new webrev:
> http://cr.openjdk.java.net/~erikj/8217032/webrev.03/index.html
>
> /Erik
>
> On 2019-02-15 14:04, Mikael Vidstedt wrote:
>> How about having the variable be called some
That would look better. Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8217032/webrev.03/index.html
/Erik
On 2019-02-15 14:04, Mikael Vidstedt wrote:
How about having the variable be called something like PANDOC_MARKDOWN_FLAG,
and have the value include “markdown”?
Cheers,
Mikael
How about having the variable be called something like PANDOC_MARKDOWN_FLAG,
and have the value include “markdown”?
Cheers,
Mikael
> On Feb 15, 2019, at 11:57 AM, Erik Joelsson wrote:
>
> Thanks for the input. Here is a new webrev that only tries to disable the
> "smart" extension if it is
Thanks for the input. Here is a new webrev that only tries to disable
the "smart" extension if it is present.
http://cr.openjdk.java.net/~erikj/8217032/webrev.02/index.html
/Erik
On 2019-02-14 23:34, Magnus Ihse Bursie wrote:
On 2019-02-15 00:26, Erik Joelsson wrote:
Please review this minor
On 2019-02-15 00:26, Erik Joelsson wrote:
Please review this minor fix. The JDK build now has support for
generating man pages, and will try to do so if it finds pandoc on the
system. Unfortunately, not all versions of pandoc are valid, and if a
bad version is found, the build will fail. This p
Looks fine. I'll be happy to have this fix !
-phil.
On 2/14/2019 3:26 PM, Erik Joelsson wrote:
Please review this minor fix. The JDK build now has support for
generating man pages, and will try to do so if it finds pandoc on the
system. Unfortunately, not all versions of pandoc are valid, and
Looks good.
Cheers,
Mikael
> On Feb 14, 2019, at 3:26 PM, Erik Joelsson wrote:
>
> Please review this minor fix. The JDK build now has support for generating
> man pages, and will try to do so if it finds pandoc on the system.
> Unfortunately, not all versions of pandoc are valid, and if a
