On 2019-09-30 17:23, Erik Joelsson wrote:
Uploaded new webrev in place with a comment explaining this.
I see.
Thanks for adding this as a comment in the code.
Looks good to me. (But as always I'm still worried that meddling with
these path functions will break unexpectedly somewhere else..
Uploaded new webrev in place with a comment explaining this.
/Erik
On 2019-09-30 08:02, Erik Joelsson wrote:
On 2019-09-30 02:41, Magnus Ihse Bursie wrote:
On 2019-09-28 00:37, Erik Joelsson wrote:
In my recent change JDK-8206125, I introduced a bash conditional
that checks if a string starts
On 2019-09-30 02:41, Magnus Ihse Bursie wrote:
On 2019-09-28 00:37, Erik Joelsson wrote:
In my recent change JDK-8206125, I introduced a bash conditional that
checks if a string starts with ~. That check seems to fail on some
Linux systems unless the ~ is quoted.
Do you need the check? The old
On 2019-09-28 00:37, Erik Joelsson wrote:
In my recent change JDK-8206125, I introduced a bash conditional that
checks if a string starts with ~. That check seems to fail on some
Linux systems unless the ~ is quoted.
Do you need the check? The old code, prior to JDK-8206125,
unconditionally mad
Looks good, ... although I question whether any Unix program other than the
shell itself should be trying to do tilde-path-expansion.
Consider fixing the code by deleting it.
On Fri, Sep 27, 2019 at 3:42 PM Erik Joelsson
wrote:
> In my recent change JDK-8206125, I introduced a bash conditional t
Erik:
In my recent change JDK-8206125, I introduced a bash conditional that
checks if a string starts with ~. That check seems to fail on some Linux
systems unless the ~ is quoted.
That's a very dark corner for the shell to be in...
Bug: https://bugs.openjdk.java.net/browse/JDK-8231594
Web
