Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-26 Thread Dalibor Topic
Hi Magnus, I'll put opening the bug and creating a patch on my little pile of things to do ... eventually, so no worries. cheers, dalibor topic On 25.02.2020 16:33, Magnus Ihse Bursie wrote: Hi Dalibor, I just pushed this. Are your suggestions important enough that I should open a separate

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-25 Thread Magnus Ihse Bursie
Hi Dalibor, I just pushed this. Are your suggestions important enough that I should open a separate bug? /Magnus > 25 feb. 2020 kl. 10:45 skrev Dalibor Topic : > > Some small suggestions: > >> On 21.02.2020 16:05, Magnus Ihse Bursie wrote: >> aot enable ahead of time co

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-25 Thread Dalibor Topic
Some small suggestions: On 21.02.2020 16:05, Magnus Ihse Bursie wrote:   aot enable ahead of time compilation (AOT)   cds enable class data sharing (CDS)   compiler1   enable hotspot compiler C1   compiler2   enable hotspot comp

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-25 Thread Per Liden
On 2/25/20 9:43 AM, Magnus Ihse Bursie wrote: On 2020-02-24 13:41, Per Liden wrote: You forgot to change "ZGC garbage collector" -> "Z garbage collector". That's very diligent of you. :-) However, I didn't forgot -- I published the webrev just before your comment about s/ZGC/Z/, and as I said,

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-25 Thread Magnus Ihse Bursie
On 2020-02-24 13:41, Per Liden wrote: You forgot to change "ZGC garbage collector" -> "Z garbage collector". That's very diligent of you. :-) However, I didn't forgot -- I published the webrev just before your comment about s/ZGC/Z/, and as I said, I will fix this before pushing (as I now have)

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Erik Joelsson
Looks good to me as long as everyone is happy with the descriptions. /Erik On 2020-02-24 00:53, Magnus Ihse Bursie wrote: On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Per Liden
You forgot to change "ZGC garbage collector" -> "Z garbage collector". /Per On 2/24/20 9:53 AM, Magnus Ihse Bursie wrote: On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Magnus Ihse Bursie
On 2020-02-24 11:23, Per Liden wrote: Hi Magnus, On 2/21/20 5:35 PM, Magnus Ihse Bursie wrote: On 2020-02-21 17:26, Erik Joelsson wrote: Baring any component specific opinions on the suggested descriptions of each feature, the patch looks good to me. Ok, I'm sending a copy of this to hotspot-d

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-24 Thread Magnus Ihse Bursie
On 2020-02-21 16:36, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :) I updated the code but will not send out a new webrev. Actually, I am sending out a new webrev, just to make sure I do t

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-23 Thread David Holmes
On 22/02/2020 2:24 am, Roger Riggs wrote: Hi, I would suggest "Java Flight Recorder"  instead of "JDK Flight Recorder" No it is "JDK Flight Recorder" as Erik stated. Though the feature, as defined by JEP 328, is just Flight Recorder. Cheers, David Regards, Roger On 2/21/20 10:36 AM, Magn

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Magnus Ihse Bursie
On 2020-02-21 17:26, Erik Joelsson wrote: Baring any component specific opinions on the suggested descriptions of each feature, the patch looks good to me. Ok, I'm sending a copy of this to hotspot-dev as well for the HS guys to bikeshed about the descriptions. I'll get back in a few days when t

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Magnus Ihse Bursie
On 2020-02-21 17:03, John Paul Adrian Glaubitz wrote: On 2/21/20 4:36 PM, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :) I updated the code but will not send out a new webrev. Shouldn't "d

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Roger Riggs
Hi, I would suggest "Java Flight Recorder"  instead of "JDK Flight Recorder" Regards, Roger On 2/21/20 10:36 AM, Magnus Ihse Bursie wrote: On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :) I updated the code but will

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Erik Joelsson
Baring any component specific opinions on the suggested descriptions of each feature, the patch looks good to me. /Erik On 2020-02-21 07:05, Magnus Ihse Bursie wrote: The JVM feature rewrite was actually somewhat of a step backwards in terms of presenting information for the user what differen

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread John Paul Adrian Glaubitz
On 2/21/20 4:36 PM, Magnus Ihse Bursie wrote: > On 2020-02-21 16:15, Erik Gahlin wrote: >> jfr should be JDK Flight Recorder. > Thanks, I should have checked and not guessed. :) > > I updated the code but will not send out a new webrev. Shouldn't "deprecated-ports" be parts of that list as well?

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Magnus Ihse Bursie
On 2020-02-21 16:15, Erik Gahlin wrote: jfr should be JDK Flight Recorder. Thanks, I should have checked and not guessed. :) I updated the code but will not send out a new webrev. /Magnus Erik On 2020-02-21 16:05, Magnus Ihse Bursie wrote: The JVM feature rewrite was actually somewhat of a

Re: RFR: JDK-8239789 Follow-up on JVM feature rewrite

2020-02-21 Thread Erik Gahlin
jfr should be JDK Flight Recorder. Erik On 2020-02-21 16:05, Magnus Ihse Bursie wrote: The JVM feature rewrite was actually somewhat of a step backwards in terms of presenting information for the user what different configure arguments do. I've compensated for this by making it far better! :