Re: RFR: JDK-8242629 Remove references to deprecated java.util.Observer and Observable

2020-04-14 Thread Chris Plummer
Hi Magnus, Some minor mistakes below, but otherwise looks good. Also copyrights need updating. I don't need to see another webrev. thanks, Chris --- old/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java 2020-04-14 12:47:05.098156117 +0200 +++ new/src/j

Re: RFR: JDK-8242629 Remove references to deprecated java.util.Observer and Observable

2020-04-14 Thread serguei.spit...@oracle.com
Hi Magnus, This looks okay to me unless there is a better solution. Thanks, Serguei On 4/14/20 04:04, Magnus Ihse Bursie wrote: As a first step towards fixing deprecation warnings in SA, all the references (200+) to the deprecated java.util.Observer and Observable needs to be fixed, otherwise

Re: RFR: JDK-8242629 Remove references to deprecated java.util.Observer and Observable

2020-04-14 Thread Erik Joelsson
Hello Magnus, I'll let someone else judge the validity of the approach, though I think it seems ok. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java: Double imports. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java: Triple i