Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-18 Thread David Holmes
Hi EriK, On 18/04/2020 1:13 am, Erik Joelsson wrote: Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html Boot JDK bump and new code to set source/target looks good. I d

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Jan Lahoda
Looks good to me, Erik! Jan On 17. 04. 20 17:13, Erik Joelsson wrote: Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html /Erik On 2020-04-17 02:41, Jan Lahoda wrote: S

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Magnus Ihse Bursie
On 2020-04-17 17:13, Erik Joelsson wrote: Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html Looks good to me. /Magnus /Erik On 2020-04-17 02:41, Jan Lahoda wrote:

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Erik Joelsson
Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html /Erik On 2020-04-17 02:41, Jan Lahoda wrote: Should the boot JDK's source and target level be updated to 14 as well, s

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Magnus Ihse Bursie
On 2020-04-17 11:41, Jan Lahoda wrote: Should the boot JDK's source and target level be updated to 14 as well, so that the interim javac can use JDK 14 features? Or is that automatic? I can still see -source 13 here: https://github.com/openjdk/jdk/blob/07156dd25b0ac468681b33181516bab34bb0c93d/

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Jan Lahoda
Should the boot JDK's source and target level be updated to 14 as well, so that the interim javac can use JDK 14 features? Or is that automatic? I can still see -source 13 here: https://github.com/openjdk/jdk/blob/07156dd25b0ac468681b33181516bab34bb0c93d/make/autoconf/boot-jdk.m4#L348 Thanks,

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-17 Thread Magnus Ihse Bursie
On 2020-04-16 18:54, Erik Joelsson wrote: JDK 14 is now GA. The minimum boot JDK version for mainline/JDK 15 should be bumped to this version. Bug: https://bugs.openjdk.java.net/browse/JDK-8242863 Webrev: http://cr.openjdk.java.net/~erikj/8242863/webrev.01/index.html Looks good to me. /Magnu

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

2020-04-16 Thread Joe Darcy
Looks fine Erik; thanks, -Joe On 4/16/2020 9:54 AM, Erik Joelsson wrote: JDK 14 is now GA. The minimum boot JDK version for mainline/JDK 15 should be bumped to this version. Bug: https://bugs.openjdk.java.net/browse/JDK-8242863 Webrev: http://cr.openjdk.java.net/~erikj/8242863/webrev.01/inde