Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-29 Thread Mandy Chung
Looks good to me. Mandy On 5/25/19 1:49 PM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-28 Thread David Holmes
Thanks Erik! David On 28/05/2019 11:35 pm, Erik Joelsson wrote: Looks good! /Erik On 2019-05-24 22:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-28 Thread Erik Joelsson
Looks good! /Erik On 2019-05-24 22:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-25 Thread David Holmes
Hi Dan, Thanks for taking a look at this. On 25/05/2019 11:11 pm, Daniel D. Daugherty wrote: On 5/25/19 1:49 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ make/hotspot/gensrc/GenerateSources.gmk    

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-25 Thread Daniel D. Daugherty
On 5/25/19 1:49 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ make/hotspot/gensrc/GenerateSources.gmk     No comments. src/hotspot/share/Xusage.txt     Deleted file. Thumbs up! When I did a sanity

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-25 Thread David Holmes
Hi Alan, Thanks for taking a look. On 25/05/2019 4:43 pm, Alan Bateman wrote: On 25/05/2019 06:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-25 Thread Alan Bateman
On 25/05/2019 06:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this information was provided in