Looks good to me now.
/Erik
On 2013-01-08 09:02, David Holmes wrote:
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
I've addressed the minor suggestions that have been given by Kelly and
Erik eg:
On 9/01/2013 8:23 AM, Kelly O'Hair wrote:
On Jan 8, 2013, at 12:02 AM, David Holmes wrote:
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
They look ok to me.
Thanks.
I've addressed the minor
On Jan 8, 2013, at 12:02 AM, David Holmes wrote:
> I have updated webrevs:
>
> http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
>
> http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
They look ok to me.
>
> I've addressed the minor suggestions that have been given by Kelly
I have updated webrevs:
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.top/
http://cr.openjdk.java.net/~dholmes/8004265.v2/webrev.jdk/
I've addressed the minor suggestions that have been given by Kelly and
Erik eg:
- better comment on the jarreorder change (and a CR to follow up)
- the
Hi Erik,
On 4/01/2013 12:15 AM, Erik Joelsson wrote:
Hello,
Sorry for taking so long responding to this. Here are my thoughts on it.
Thanks for getting to it, I know you have a lot on your plate at the moment.
I like the idea of defined sets of files for each type of image. The
current Imag
Hello,
Sorry for taking so long responding to this. Here are my thoughts on it.
I like the idea of defined sets of files for each type of image. The
current Images.gmk works with excludes, because that's how it used to
work, but I would be happy to change to an include based process. Then
we
On Dec 21, 2012, at 5:01 PM, David Holmes wrote:
> On 22/12/2012 10:11 AM, Kelly O'Hair wrote:
>> On Dec 21, 2012, at 3:27 PM, David Holmes wrote:
On JarReorder.java, it seems like you have just deleted a warning that
someone explicitly asked for
a class to be included, and also ex
On 22/12/2012 10:11 AM, Kelly O'Hair wrote:
On Dec 21, 2012, at 3:27 PM, David Holmes wrote:
On JarReorder.java, it seems like you have just deleted a warning that
someone explicitly asked for
a class to be included, and also explicitly asked for that class to be
excluded.
If we are changing the
On Dec 21, 2012, at 3:27 PM, David Holmes wrote:
> On 22/12/2012 1:18 AM, Kelly O'Hair wrote:
>>
>> On Dec 20, 2012, at 10:18 PM, David Holmes wrote:
>>
>>> webrevs:
>>>
>>> top-level repo:http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/
>>
>> These comments in Main.gmk don't seem to m
On 22/12/2012 1:18 AM, Kelly O'Hair wrote:
On Dec 20, 2012, at 10:18 PM, David Holmes wrote:
webrevs:
top-level repo:http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/
These comments in Main.gmk don't seem to make sense:
117 # Note: This double-colon rule is intentional, to support
11
21 dec 2012 kl. 16:18 skrev Kelly O'Hair :
> These comments in Main.gmk don't seem to make sense:
>
> 117 # Note: This double-colon rule is intentional, to support
> 118 # custom make file integration.
> 119 images:: source-tips demos images-only
>
> Do lines 117 and 118 just need to be deleted?
On Dec 20, 2012, at 10:18 PM, David Holmes wrote:
> webrevs:
>
> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/
These comments in Main.gmk don't seem to make sense:
117 # Note: This double-colon rule is intentional, to support
118 # custom make file integration.
119
12 matches
Mail list logo
