Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-07 Thread Daniel D. Daugherty
Adding back [email protected] and [email protected] Reminder: "reply to list" only replies to _one_ list. On 8/7/13 7:46 AM, Coleen Phillimore wrote: Dan, this looks good. Thank you for fixing it Thanks for the review! and removing the old core build, which is

Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Daniel D. Daugherty
Ron, Thanks for the review! Dan On 8/6/13 6:19 PM, Ron Durbin wrote: Your code looks good and it resolves the reported defect. -Original Message- From: Daniel D. Daugherty Sent: Friday, August 02, 2013 4:36 PM To: [email protected]; [email protected]

Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Daniel D. Daugherty
Thanks for being another tester for these changes! Just curious: which OS and VS version? Dan On 8/6/13 6:01 PM, Mikael Vidstedt wrote: Dan, I have not reviewed the actual changes, but FWIW I have verified that applying the patch does solve the linker error you mention. Thanks a lot for f

RE: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Ron Durbin
Your code looks good and it resolves the reported defect. > -Original Message- > From: Daniel D. Daugherty > Sent: Friday, August 02, 2013 4:36 PM > To: [email protected]; > [email protected]; build-dev > Subject: code review (round 0) request for VS2

Re: code review (round 0) request for VS2010 IDE fix (8016601)

2013-08-06 Thread Mikael Vidstedt
Dan, I have not reviewed the actual changes, but FWIW I have verified that applying the patch does solve the linker error you mention. Thanks a lot for fixing! Cheers, Mikael On 2013-08-02 15:36, Daniel D. Daugherty wrote: Greetings, I have have a proposed fix for the following bug: