Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-22 Thread Magnus Ihse Bursie
On 2012-05-22 03:48, Kelly O'Hair wrote: On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: On 2012-05-02 00:19, Kelly Ohair wrote: Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. Yes, I still like to have

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-21 Thread Kelly O'Hair
On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: On 2012-05-02 00:19, Kelly Ohair wrote: Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. Yes, I still like to have this integrated. (Sorry for the slow

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-14 Thread Magnus Ihse Bursie
On 2012-05-02 00:19, Kelly Ohair wrote: Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.)

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-01 Thread Kelly Ohair
Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. -kto Sent from my iPhone On Apr 26, 2012, at 0:35, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: On 2012-04-26 03:06, Jim Graham wrote: Can we remove

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-30 Thread Chris Hegarty
On 27/04/2012 21:37, Jim Graham wrote: Thanks, sorry, I missed the part where this was responding to a change that is already under way in the new build system... Right, but it would be nice to trivially cleanup (remove these files) from FILES_export list in the old build system. -Chris.

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-27 Thread Jim Graham
Thanks, sorry, I missed the part where this was responding to a change that is already under way in the new build system... ...jim On 4/26/12 12:35 AM, Magnus Ihse Bursie wrote: On 2012-04-26 03:06, Jim Graham wrote: Can we remove these empty JNI classes from a list of javah

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-26 Thread Magnus Ihse Bursie
On 2012-04-26 03:06, Jim Graham wrote: Can we remove these empty JNI classes from a list of javah classes somewhere so that we don't waste time generating the empty JNI headers? Good idea -- that's exactly what is being done in the new build system (the build-infra project)! :-) We added a

Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Magnus Ihse Bursie
There are a few files native files in AWT and Java2d, which include generated JNI header files, but the corresponding header files are empty, since the class contains neither native methods nor constants. All of them have probably been useful at one point in time, but then the Java code

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Phil Race
Looks fine. If its not a pain, 2d forest would probably be the most appropriate as 3/4 are 2D .. -phil. On 4/25/2012 8:27 AM, Chris Hegarty wrote: [ cc'ing awt-dev 2d-dev ] The change looks fine Magnus, though it may be best to push through the awt or 2d forest. Members of these groups,

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Jim Graham
Can we remove these empty JNI classes from a list of javah classes somewhere so that we don't waste time generating the empty JNI headers? ...jim On 4/25/12 8:27 AM, Chris Hegarty wrote: [ cc'ing awt-dev 2d-dev ] The change looks fine Magnus, though it may be best to