Re: Request for review: always generate java-rmi.cgi

2011-06-24 Thread Peter Jones
On May 11, 2011, at 1:57 PM, Mandy Chung wrote: On 05/11/11 10:50, Kelly O'Hair wrote: >> On May 11, 2011, at 10:47 AM, Alan Bateman wrote: Q2: Does it belong somewhere other than the bin directory? >>> The script can be used to tunnel RMI calls over HTTP. Probably legacy now >>>

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Omair Majid
On 05/11/2011 09:50 PM, Kelly O'Hair wrote: Please review this change: 7043921: generate java-rmi.cgi on 64 bit platform http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/ I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^) If, as the o

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
On May 11, 2011, at 6:59 PM, David Katleman wrote: > > > On 5/11/2011 6:50 PM, Kelly O'Hair wrote: >> Please review this change: >> >> 7043921: generate java-rmi.cgi on 64 bit platform >> http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/ >> >> I think this works for you guys

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread David Katleman
On 5/11/2011 6:50 PM, Kelly O'Hair wrote: Please review this change: 7043921: generate java-rmi.cgi on 64 bit platform http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/ I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^) Was this revie

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
Please review this change: 7043921: generate java-rmi.cgi on 64 bit platform http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/ I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^) -kto

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
On May 11, 2011, at 1:33 PM, Omair Majid wrote: > Also, given that you have written up a more correct patch, perhaps you should > be committing it instead? Let me take care of this. I'll send out a webrev shortly. -kto

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Dr Andrew John Hughes
On 21:09 Wed 11 May , Dmitry Samersoff wrote: > Omair, > > CR 7043921 . It need someone from jdk team to integrate it. > Omair has commit rights so he can just push it now. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Omair Majid
On 05/11/2011 01:49 PM, Kelly O'Hair wrote: On May 11, 2011, at 10:35 AM, Omair Majid wrote: Q2: Does it belong somewhere other than the bin directory? I am not sure. It is not supposed to be executed directly by a user. But it is an executable file. I think the extension makes it clear th

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Mandy Chung
On 05/11/11 10:50, Kelly O'Hair wrote: On May 11, 2011, at 10:47 AM, Alan Bateman wrote: Q2: Does it belong somewhere other than the bin directory? The script can be used to tunnel RMI calls over HTTP. Probably legacy now and I'm pretty sure that java-rmi.cgi is just meant to be an examp

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
On May 11, 2011, at 10:47 AM, Alan Bateman wrote: >> >> Q2: Does it belong somewhere other than the bin directory? >> >> > The script can be used to tunnel RMI calls over HTTP. Probably legacy now and > I'm pretty sure that java-rmi.cgi is just meant to be an example script. The > RMI FAQ p

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
On May 11, 2011, at 10:35 AM, Omair Majid wrote: >> >> Q2: Does it belong somewhere other than the bin directory? >> > > I am not sure. It is not supposed to be executed directly by a user. But it > is an executable file. I think the extension makes it clear that only a HTTP > server is supp

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Alan Bateman
Kelly O'Hair wrote: I found this bug: http://bugs.sun.com/view_bug.do?bug_id=4495986 Which seems to imply that maybe this java-rmi.cgi file doesn't belong in the "bin" directory at all? But it also seems to me that the current: 91 ifneq ($(ARCH_DATA_MODEL), 32) 92 build: stubs 93 else

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Omair Majid
On 05/11/2011 01:03 PM, Kelly O'Hair wrote: I found this bug: http://bugs.sun.com/view_bug.do?bug_id=4495986 Which seems to imply that maybe this java-rmi.cgi file doesn't belong in the "bin" directory at all? But it also seems to me that the current: 91 ifneq ($(ARCH_DATA_MODEL), 32)

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Dmitry Samersoff
Omair, CR 7043921 . It need someone from jdk team to integrate it. -Dmitry On 2011-05-11 20:17, Omair Majid wrote: On 05/09/2011 04:02 PM, Dmitry Samersoff wrote: Omair, Will do it tomorrow. Ping. Just in case you forgot. Thanks, Omair -- Dmitry Samersoff Java Hotspot development tea

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O'Hair
I found this bug: http://bugs.sun.com/view_bug.do?bug_id=4495986 Which seems to imply that maybe this java-rmi.cgi file doesn't belong in the "bin" directory at all? But it also seems to me that the current: 91 ifneq ($(ARCH_DATA_MODEL), 32) 92 build: stubs 93 else # ARCH_DATA_MODEL 9

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Omair Majid
On 05/09/2011 04:02 PM, Dmitry Samersoff wrote: Omair, Will do it tomorrow. Ping. Just in case you forgot. Thanks, Omair

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Dr Andrew John Hughes
On 17:32 Tue 10 May , Kelly O'Hair wrote: > > I'm a little reluctant to accept this, I'm not sure what the full > ramifications are. > But I think we want it. > > Is this in OpenJDK6 now? > OpenJDK6 changes have to go through 7 first, so no. But it's been in IcedTea6 since before there w

Re: Request for review: always generate java-rmi.cgi

2011-05-10 Thread Kelly O'Hair
I'm a little reluctant to accept this, I'm not sure what the full ramifications are. But I think we want it. Is this in OpenJDK6 now? -kto On May 6, 2011, at 1:49 PM, Omair Majid wrote: > Hi, > > Could someone kindly review the patch at: > http://cr.openjdk.java.net/~omajid/webrevs/rmi-cgi-b

Re: Request for review: always generate java-rmi.cgi

2011-05-09 Thread Dmitry Samersoff
Omair, Will do it tomorrow. -Dmitry On 2011-05-09 18:07, Omair Majid wrote: On 05/09/2011 02:17 AM, Dmitry Samersoff wrote: Omair, Looks good for me. Great! May I have a bug id, please? Thanks, Omair -Dmitry On 2011-05-07 00:49, Omair Majid wrote: Hi, Could someone kindly review the

Re: Request for review: always generate java-rmi.cgi

2011-05-09 Thread Omair Majid
On 05/09/2011 02:17 AM, Dmitry Samersoff wrote: Omair, Looks good for me. Great! May I have a bug id, please? Thanks, Omair -Dmitry On 2011-05-07 00:49, Omair Majid wrote: Hi, Could someone kindly review the patch at: http://cr.openjdk.java.net/~omajid/webrevs/rmi-cgi-bin/01/ The patch

Re: Request for review: always generate java-rmi.cgi

2011-05-08 Thread Dmitry Samersoff
Omair, Looks good for me. -Dmitry On 2011-05-07 00:49, Omair Majid wrote: Hi, Could someone kindly review the patch at: http://cr.openjdk.java.net/~omajid/webrevs/rmi-cgi-bin/01/ The patch causes the shell script java-rmi.cgi to be built regardless of the arch (32/64 bit) on all non-windows

Request for review: always generate java-rmi.cgi

2011-05-06 Thread Omair Majid
Hi, Could someone kindly review the patch at: http://cr.openjdk.java.net/~omajid/webrevs/rmi-cgi-bin/01/ The patch causes the shell script java-rmi.cgi to be built regardless of the arch (32/64 bit) on all non-windows platforms. I don't see anything in that script that requires a 32-bit platfo