Re: Request for review: support building hotspot with gcc 4.6

2011-05-02 Thread Dmitry Samersoff
Omair, I'd filled 7041156 for you and I'll take care of the fix. -Dmitry On 2011-05-02 19:47, Omair Majid wrote: On 04/30/2011 05:47 AM, Dmitry Samersoff wrote: Omair, I'm second to David Holmes, -Xlinker forks fine since gcc 2.8.1 and I think we don't need any bracketing here. Personally

Re: Request for review: support building hotspot with gcc 4.6

2011-05-02 Thread Omair Majid
On 05/02/2011 03:10 PM, Dmitry Samersoff wrote: I'd filled 7041156 for you and I'll take care of the fix. Thanks. Much appreciated! Cheers, Omair

Re: Request for review: support building hotspot with gcc 4.6

2011-05-02 Thread Omair Majid
On 04/30/2011 05:47 AM, Dmitry Samersoff wrote: Omair, I'm second to David Holmes, -Xlinker forks fine since gcc 2.8.1 and I think we don't need any bracketing here. Personally I prefer -Xlinker over -Wl, because of better visibility. Ok, I have changed -Wl, to -Xlinker: http://cr.openjdk.j

Re: Request for review: support building hotspot with gcc 4.6

2011-04-30 Thread Dmitry Samersoff
Omair, I'm second to David Holmes, -Xlinker forks fine since gcc 2.8.1 and I think we don't need any bracketing here. Personally I prefer -Xlinker over -Wl, because of better visibility. -Dmitry On 2011-04-30 06:43, David Holmes wrote: Erik Trimble said the following on 04/30/11 10:27: O

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread David Holmes
Erik Trimble said the following on 04/30/11 10:27: On 4/29/2011 5:17 PM, David Holmes wrote: David Katleman said the following on 04/30/11 09:13: On 4/29/2011 3:59 PM, Omair Majid wrote: http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot wi

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread Erik Trimble
On 4/29/2011 5:17 PM, David Holmes wrote: Dave, David Katleman said the following on 04/30/11 09:13: Hi Omair! On 4/29/2011 3:59 PM, Omair Majid wrote: Hi, http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot with gcc 4.6. gcc 4.6 changed h

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread David Holmes
Dave, David Katleman said the following on 04/30/11 09:13: Hi Omair! On 4/29/2011 3:59 PM, Omair Majid wrote: Hi, http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot with gcc 4.6. gcc 4.6 changed how arguments are handled. It now treats -ex

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread Kelly O'Hair
The same hotspot sources and makefile deliver into our JDK6 releases, and formal builds of JDK6 are done on some very old Linux systems, RH2.1?, which I think is before 2000. -kto On Apr 29, 2011, at 4:34 PM, Omair Majid wrote: > On 04/29/2011 07:13 PM, David Katleman wrote: >> Hi Omair! >> >

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread Omair Majid
On 04/29/2011 07:13 PM, David Katleman wrote: Hi Omair! On 4/29/2011 3:59 PM, Omair Majid wrote: Hi, http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot with gcc 4.6. gcc 4.6 changed how arguments are handled. It now treats -export-dynamic as

Re: Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread David Katleman
Hi Omair! On 4/29/2011 3:59 PM, Omair Majid wrote: Hi, http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot with gcc 4.6. gcc 4.6 changed how arguments are handled. It now treats -export-dynamic as it treats any other -efoo option: it thinks

Request for review: support building hotspot with gcc 4.6

2011-04-29 Thread Omair Majid
Hi, http://cr.openjdk.java.net/~omajid/webrevs/gcc-46-support/ The patch adds support for building hotspot with gcc 4.6. gcc 4.6 changed how arguments are handled. It now treats -export-dynamic as it treats any other -efoo option: it thinks xport-dynamic is the entry point and passes this inf