Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

The parts of this which I know about (the client licenses) look fine to me. Some day we should look at whether we still have vestiges of X11 in the Mac code from the BSD port but for now its safer to assume there are .. By this I mean "unix" includes Mac. as a core OS, but not as a desktop

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

Looks good, thanks! /Erik On 2016-12-10 08:54, Mandy Chung wrote: On Dec 9, 2016, at 11:51 PM, Erik Joelsson wrote: Hello Mandy, In Copy-java.base.gmk. Modules.gmk is no longer needed. JMOD_* varaibles are no longer used. Good catch. In Main.gmk, it would be

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

Erik, Magnus, I have made the change per your suggestion: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.01/ Jeannette, Jeff, and I went through all .md files and I think asm.md is the only one got the characters messed up. These files are contributed by Jeannette. Also,

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

> On Dec 8, 2016, at 9:43 AM, Alan Bateman wrote: > > On 07/12/2016 21:28, Mandy Chung wrote: > >> : >> >> Webrev at: >>http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.00/ >> >> > I went over the changes to the jmod tool, jlink, and the new plugin

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

On 07/12/2016 21:28, Mandy Chung wrote: : Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169925/webrev.00/ I went over the changes to the jmod tool, jlink, and the new plugin to dedup legal notices. It looks straight-forward, I just wondering about the sym links hat

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

> On Dec 8, 2016, at 2:58 AM, Magnus Ihse Bursie > wrote: > > Hi Mandy, > > Some comments. > > * In CreateJmods.gmk, you remove the TODO about headers, but I don't see a > resolution to that issue here. If you have opened a bug report for that > instead,

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

> On Dec 8, 2016, at 1:44 AM, Erik Joelsson wrote: > > Hello Mandy, > > In autoconf you are also adding a "man" dir, is this intended with this > change? > Strictly speaking this is a separate issue but piggyback it here. This may be used when building JDK with

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

Hi Mandy, Some comments. * In CreateJmods.gmk, you remove the TODO about headers, but I don't see a resolution to that issue here. If you have opened a bug report for that instead, please let me know the bug ID. * The definitions of JDK/JMOD_COPYRIGHT/LICENSE in Modules.gmk seems to be

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

On 08/12/2016 09:44, Erik Joelsson wrote: : In make/InterimImage.gmk, -J-Djlink.debug=true looks like left over debug code. I'd prefer to keep this as t's really hard to debug issues when jlink fails in the build. -Alan.

Re: Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

Hi Mandy, Just noticed that the CLDR license is located under jdk.localedata module. That needs to be moved into java.base, as its English resource files are derived from CLDR too. Naoto On 12/7/16 1:28 PM, Mandy Chung wrote: This proposes to organize license files by module in source,

Review Request JDK-8169925: Organize licenses by module in source, JMOD file, and run-time image

This proposes to organize license files by module in source, JMOD, and run-time image. A summary of the proposal: 1. Organize third party notices by module in the source as follows: src/$MODULE/{share,$OS}/legal/* The `legal` directory contains one file for each third party library in the