Re: Review request: Shark buildsystem changes

2010-08-16 Thread Dr Andrew John Hughes
On 16 August 2010 10:22, Gary Benson wrote: > Dr Andrew John Hughes wrote: >> On 13 August 2010 16:58, Kelly O'Hair wrote: >> > We are currently discussing whether we want to continue using the >> > jdk7/build forest, and instead use the jdk7/tl forest for build >> > changes. No final decision ha

Re: Review request: Shark buildsystem changes

2010-08-16 Thread Gary Benson
Dr Andrew John Hughes wrote: > On 13 August 2010 16:58, Kelly O'Hair wrote: > > We are currently discussing whether we want to continue using the > > jdk7/build forest, and instead use the jdk7/tl forest for build > > changes. No final decision has been made, but I see no issue with > > this chang

Re: Review request: Shark buildsystem changes

2010-08-13 Thread Dr Andrew John Hughes
On 13 August 2010 16:58, Kelly O'Hair wrote: > > On Aug 13, 2010, at 1:49 AM, Gary Benson wrote: > >> Dalibor Topic wrote: >>> >>> On 8/12/10 10:58 PM, Kelly O'Hair wrote: > > There isn't a document but I'm happy to write one if you'd like, > either as a section of README-builds.html o

Re: Review request: Shark buildsystem changes

2010-08-13 Thread Kelly O'Hair
On Aug 13, 2010, at 1:49 AM, Gary Benson wrote: Dalibor Topic wrote: On 8/12/10 10:58 PM, Kelly O'Hair wrote: There isn't a document but I'm happy to write one if you'd like, either as a section of README-builds.html or a file in it's own right. Shall I do that? Adding a section to the REA

Re: Review request: Shark buildsystem changes

2010-08-13 Thread Gary Benson
Dalibor Topic wrote: > On 8/12/10 10:58 PM, Kelly O'Hair wrote: > > > There isn't a document but I'm happy to write one if you'd like, > > > either as a section of README-builds.html or a file in it's own > > > right. Shall I do that? > > > > Adding a section to the README-builds.html file on ZER

Re: Review request: Shark buildsystem changes

2010-08-12 Thread Dalibor Topic
On 8/12/10 10:58 PM, Kelly O'Hair wrote: >> There isn't a document but I'm happy to write one if you'd like, >> either as a section of README-builds.html or a file in it's own >> right. Shall I do that? > > Adding a section to the README-builds.html file on ZERO/SHARK builds seems > like a good

Re: Review request: Shark buildsystem changes

2010-08-12 Thread Kelly O'Hair
On Aug 12, 2010, at 9:45 AM, Gary Benson wrote: Hi Kelly, I don't generally use the script either, and nor does IcedTea, so I guess to some extent we've been using that file as a template too. but if you're ok with having that stuff in that file then I'd rather leave it there than not, if only

Re: Review request: Shark buildsystem changes

2010-08-12 Thread Gary Benson
Hi Kelly, I don't generally use the script either, and nor does IcedTea, so I guess to some extent we've been using that file as a template too. but if you're ok with having that stuff in that file then I'd rather leave it there than not, if only because it does make figuring out how to build it e

Re: Review request: Shark buildsystem changes

2010-08-12 Thread Kelly O'Hair
I have no problem with these changes, but I must point out that the jdk_generic_profile.sh file was really meant as a template for people to understand how to setup the generic build dependencies, not necessarily picking the compiler or linker options to use in the build. I don't know of an

Review request: Shark buildsystem changes

2010-08-12 Thread Gary Benson
Hi all, Shark is a JIT compiler for Zero, the zero-assembler port of HotSpot. Shark uses the LLVM compiler infrastructure to compile Java methods without introducing system-specific code. Shark was integrated into HotSpot as 6976186, but there are a couple of build system tweaks required before S