On 2014-09-15 19:24, Mandy Chung wrote:
I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The time for verify-modules is not small and there is potential
performance improvement.
On 16/09/2014 03:04, David Holmes wrote:
At what point, if any, is javac armed with the dependency information
so that it can report any incorrect cross-module references (as we did
for Compact Profiles) ?
That is for further down the road once the module system goes in.
-Alan.
On 2014-09-13 10:05, Alan Bateman wrote:
On 12/09/2014 21:48, Mandy Chung wrote:
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module boundaries.
It's important to catch this regression early during jdk development.
On 2014-09-15 11:48, Erik Joelsson wrote:
I'm less sure about changing the default target as it adds a few
additional seconds. I wonder if this part should be left out on the
assumption that most people are likely to make sure that images build
before they push.
I would agree with Alan
My assumption is the opposite, that most people type 'make' and
nothing more, expecting that if you had to do more to test a code
change builds properly, it would be included in the default target.
If you aren't affecting the images, then you don't expect to need
to build the images.
-phil.
On
I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The time for verify-modules is not small and there is potential
performance improvement. I suspect people may use JDK_FILTER,
or
On 15/09/2014 18:24, Mandy Chung wrote:
I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The time for verify-modules is not small and there is potential
performance improvement.
On 9/15/14 10:36 AM, Alan Bateman wrote:
On 15/09/2014 18:24, Mandy Chung wrote:
I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The time for verify-modules is not small and
On 16/09/2014 4:46 AM, Mandy Chung wrote:
On 9/15/14 10:36 AM, Alan Bateman wrote:
On 15/09/2014 18:24, Mandy Chung wrote:
I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The
On 12/09/2014 21:48, Mandy Chung wrote:
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module boundaries.
It's important to catch this regression early during jdk development.
This patch proposes to add verify-modules to
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module boundaries.
It's important to catch this regression early during jdk development.
This patch proposes to add verify-modules to the default target
and also images
Looks good to me.
-phil.
On 9/12/2014 1:48 PM, Mandy Chung wrote:
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module boundaries.
It's important to catch this regression early during jdk development.
This patch
12 matches
Mail list logo
