Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
On 10/17/2012 11:53 AM, Kelly O'Hair wrote: On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: On 17/10/2012 19:33, Mandy Chung wrote: On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my loc

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Kelly O'Hair
On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: > On 17/10/2012 19:33, Mandy Chung wrote: >> On 10/17/2012 11:29 AM, Kelly O'Hair wrote: >>> Looks ok to me. Did you plan on integrating it into jdk8/build? >> >> I can do that. Thanks for reminding me - my local repo is a clone of >> jdk8/tl.

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Alan Bateman
On 17/10/2012 19:11, Mandy Chung wrote: I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JA

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Alan Bateman
On 17/10/2012 19:33, Mandy Chung wrote: On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. It probably doesn't matter if this goes in via jdk8/tl. -Alan.

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
On 10/17/2012 11:29 AM, Kelly O'Hair wrote: Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. Mandy -kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: I need a reviewer to fix this build pro

Re: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Kelly O'Hair
Looks ok to me. Did you plan on integrating it into jdk8/build? -kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: > I need a reviewer to fix this build problem that only affects partial build. > > make/common/internal/Defs-jaxws.gmk maintains an explicit list of > JAXWS packages to import

Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false

2012-10-17 Thread Mandy Chung
I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JAXWS classes. You can reproduce the proble