Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-08 Thread Mandy Chung
Thanks you all for the review. I'll rename AbstractOperatingSystemImpl before I push. Mandy On 11/8/2013 5:22 AM, Alan Bateman wrote: On 08/11/2013 08:40, Jaroslav Bachorik wrote: AbstractOperatingSystemImpl should be an abstract class as its name already indicates. Right, it probably shou

Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-08 Thread Magnus Ihse Bursie
On 2013-11-08 00:40, Mandy Chung wrote: com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false).

Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-08 Thread Erik Joelsson
Reduced complexity in makefiles is always nice to see. Build part looks good to me. /Erik On 2013-11-08 00:40, Mandy Chung wrote: com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated

Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-07 Thread Mandy Chung
com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false). This is simply refactoring of the existi