Re: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-21 Thread Erik Joelsson
d-dev@openjdk.java.net' ; 'hotspot-...@openjdk.java.net' Subject: Re: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server Hello Matthias, Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens to coincide with the

RE: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-21 Thread Baesken, Matthias
; Subject: Re: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server Hello Matthias, Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens to coincide with the set of variants that also support CDS, but I would say this correlat

Re: RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-17 Thread Erik Joelsson
Hello Matthias, Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens to coincide with the set of variants that also support CDS, but I would say this correlation is incidental. I would still prefer an explicit test for if any of the variants that do support CDS is in the set

RFR [XS]: 8237374: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-17 Thread Baesken, Matthias
Hello, please review this small patch . When building 2 VM variants minimal and server in one build and using --with-jvm-variants=minimal,server to configure this setup , the build works nicely. But I notice that in the server VM, cds is removed. Instead of checking if cds should be ena

Re: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Erik Joelsson
jdk.java.net/browse/JDK-8237374 JDK-8237374 :  configuring with --with-jvm-variants=minimal,server makes cds disappear in server Best regards, Matthias This does indeed look like a bug to me. At least at Oracle, we no longer build any multi JVM configs regularly, so things like this falls

Re: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Ioi Lam
I opened  bug : https://bugs.openjdk.java.net/browse/JDK-8237374 JDK-8237374 :  configuring with --with-jvm-variants=minimal,server makes cds disappear in server Best regards, Matthias This does indeed look like a bug to me. At least at Oracle, we no longer build any multi JVM configs regular

Re: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Erik Joelsson
bug : https://bugs.openjdk.java.net/browse/JDK-8237374 JDK-8237374 : configuring with --with-jvm-variants=minimal,server makes cds disappear in server Best regards, Matthias This does indeed look like a bug to me. At least at Oracle, we no longer build any multi JVM configs regularly, so thin

RE: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Baesken, Matthias
eck isn’t done . I opened bug : https://bugs.openjdk.java.net/browse/JDK-8237374 JDK-8237374 : configuring with --with-jvm-variants=minimal,server makes cds disappear in server Best regards, Matthias > > This does indeed look like a bug to me. At least at Oracle, we no longer > build any

Re: configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Erik Joelsson
This does indeed look like a bug to me. At least at Oracle, we no longer build any multi JVM configs regularly, so things like this falls through the cracks. /Erik On 2020-01-16 02:18, Baesken, Matthias wrote: Hello, I noticed the following strange "feature" (or is it a bug?) . When buildin

configuring with --with-jvm-variants=minimal,server makes cds disappear in server

2020-01-16 Thread Baesken, Matthias
Hello, I noticed the following strange "feature" (or is it a bug?) . When building 2 VM variants in one build and using --with-jvm-variants=minimal,server For this, the build works nicely. But I notice that in the server VM, cds is removed. Instead of checking if cds should be enabled..