Re: i18n dev [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Masayoshi Okutsu
applyParentLocales() sets parentLocalesMap before populating the map with data. It's possible that other threads look up the map without the (full) data. So, a Map (local variable) should be populated and then parentLocalesMap should be set to the Map. Also, parentLocalesMap needs to be

Re: i18n dev [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 6/25/2015 1:15 AM, Naoto Sato wrote: Thanks. Here is the diff from webrev.01 to address your comment: http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62 Naoto On 6/24/15 2:16 AM, Masayoshi Okutsu wrote: applyParentLocales() sets parentLocalesMap

Re: i18n dev [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Naoto Sato
Thanks. Here is the diff from webrev.01 to address your comment: http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62 Naoto On 6/24/15 2:16 AM, Masayoshi Okutsu wrote: applyParentLocales() sets parentLocalesMap before populating the map with data. It's possible that other threads look

Re: i18n dev [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-23 Thread Naoto Sato
Here is the updated webrev: http://cr.openjdk.java.net/~naoto/8008577/webrev.01/ As to the 3rd comment below, I did not modify it because that would simply duplicate the same piece of code in each getCandidateLocales() implementation (from the current location). Naoto On 6/19/15 1:53 AM,

Re: i18n dev [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-19 Thread Masayoshi Okutsu
Sorry for taking time. Here are my comments. src/jdk.localedata/share/classes/sun/text/resources/*JavaTimeSupplementary*.java: - The year range of the first line of the copyright header should be 2015, for the new ones and 2013, 2015, for the updated ones. - I wonder if