Re: jdk/src/solaris - time to re-visit it?

2011-12-02 Thread Magnus Ihse Bursie
On 2011-12-01 18:49, Dmitry Samersoff wrote: We have at least three options: 1. #ifdef - pro we can slowly migrate from #ifdef OpenBSD to #ifdef HAVE_MAD_LINKER cons it pollutes code and doesn't cover all cases. 2. Dir structure unix/generic

Re: jdk/src/solaris - time to re-visit it?

2011-12-01 Thread Ulf Zibis
Am 30.11.2011 18:16, schrieb Phil Race: On 11/30/2011 5:15 AM, Ulf Zibis wrote: Am 30.11.2011 13:10, schrieb Dmitry Samersoff: count me too for src/unix +1 I more would like src/posix + src/winapi Which would be wrong. Its not just posix. More of the code in src/solaris is related to UI

Re: jdk/src/solaris - time to re-visit it?

2011-12-01 Thread Dmitry Samersoff
Ulf, The problem is that (e.g.) MacOS or OpenBSD share some code from generic_unix and generic_bsd but has some unique code as well. We have to keep this logic somewhere. We have at least three options: 1. #ifdef - pro we can slowly migrate from #ifdef OpenBSD to #ifdef

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Steve Poole
On Tue, 2011-11-29 at 15:08 -0800, Phil Race wrote: Flat vs Hierarchical is OK. its needless proliferation I was objecting to. If ifdef capability can be used I have no issues with that either. I suggested maintaining the name as src/solaris partly because I don't believe in churn and am

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Dmitry Samersoff
On 2011-11-30 16:05, Steve Poole wrote: I suggested maintaining the name as src/solaris partly because I don't believe in churn and am not sure what would make a better name other than src/unix .. would that be OK ? +1 for src/unix count me too for src/unix +1 -- Dmitry Samersoff Java

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Ulf Zibis
Am 30.11.2011 13:10, schrieb Dmitry Samersoff: On 2011-11-30 16:05, Steve Poole wrote: I suggested maintaining the name as src/solaris partly because I don't believe in churn and am not sure what would make a better name other than src/unix .. would that be OK ? +1 for src/unix count me too

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Phil Race
On 11/30/2011 5:15 AM, Ulf Zibis wrote: Am 30.11.2011 13:10, schrieb Dmitry Samersoff: On 2011-11-30 16:05, Steve Poole wrote: I suggested maintaining the name as src/solaris partly because I don't believe in churn and am not sure what would make a better name other than src/unix .. would that

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Jonathan Gibbons
On 11/30/2011 09:16 AM, Phil Race wrote: unix has a better implication of more than just posix. From http://en.wikipedia.org/wiki/Unix-like The Open Group owns the UNIX trademark and administers the Single UNIX Specification, with the UNIX name being used as a certification mark. -- Jon

Re: jdk/src/solaris - time to re-visit it?

2011-11-29 Thread Steve Poole
On Mon, 2011-11-28 at 17:20 +0100, Fredrik Öhrström wrote: 2011-11-28 16:46, Ulf Zibis skrev: I guess you meant: --shared --posix |--SYSV ||--solaris ||--aix | |--gnu ||--linux || |--BSD

Re: jdk/src/solaris - time to re-visit it?

2011-11-29 Thread Phil Race
--src |--share |--posix |--winapi |--SYSV |--GNU |--BSD |--solaris |--aix |--gnu |--linux |--darwin |--freebsd |--windows |--wince * 95%+ of the code will be the same across solaris/linux/etc

Re: jdk/src/solaris - time to re-visit it?

2011-11-29 Thread Alan Bateman
On 29/11/2011 19:34, Phil Race wrote: : * 95%+ of the code will be the same across solaris/linux/etc And remember this includes all the X11 code. * Of the remaining 5%, most of it is best dealt with via ifdef because its a few line delta in a large file. I'd guess 2% of the code might

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Ulf Zibis
Am 27.11.2011 22:29, schrieb Mike Duigou: Only if necessary hopefully. As we have shared and platform code we might have shared |--posix ||--SYSV |||--solaris |||--aix || ||--gnu |||--linux ||| ||--BSD |

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Fredrik Öhrström
2011-11-28 16:46, Ulf Zibis skrev: I guess you meant: --shared --posix |--SYSV ||--solaris ||--aix | |--gnu ||--linux || |--BSD |--darwin |--freebsd --winapi |--win32 |--wince

Re: jdk/src/solaris - time to re-visit it?

2011-11-28 Thread Ulf Zibis
Additionaly I think, 'share' should be replaced by 'common'. 'share', as a verb, seems ugly along 'posix', 'winapi' to me. -Ulf Am 28.11.2011 17:20, schrieb Fredrik Öhrström: 2011-11-28 16:46, Ulf Zibis skrev: I guess you meant: --shared --posix |--SYSV ||--solaris

Re: jdk/src/solaris - time to re-visit it?

2011-11-27 Thread Mike Duigou
On Thu, 24 Nov 2011 15:39:59 +0100 Fredrik ?hrstr?m fredrik.ohrst...@oracle.com wrote : When we rename directories, we lose a lot of information in the source control system. hg moves don't cause any of the history to be lost. Some tools (including NetBeans) follow the history through

Re: jdk/src/solaris - time to re-visit it?

2011-11-27 Thread David Holmes
On 28/11/2011 7:29 AM, Mike Duigou wrote: On Thu, 24 Nov 2011 15:39:59 +0100 Fredrik ?hrstr?mfredrik.ohrst...@oracle.com wrote : When we rename directories, we lose a lot of information in the source control system. hg moves don't cause any of the history to be lost. Some tools

Re: jdk/src/solaris - time to re-visit it?

2011-11-25 Thread Alan Bateman
On 24/11/2011 14:39, Fredrik Öhrström wrote: : It would be great to do the rename. However, we should not do that before the build-infra changes are in place. The peculiarities of the current build have already been worked around and the new makefiles are useful, since it is easy to see where

OT: jdk/build/solaris (was Re: jdk/src/solaris - time to re-visit it?)

2011-11-25 Thread Weijun Wang
Off topic. I don't have any suggestion on src and make at the moment but is it good to build platform-specific binaries into different directories and keep the common files at a single place? If so we can create a single merged image that is executable everywhere. -Max On 11/25/2011 06:59

Re: jdk/src/solaris - time to re-visit it?

2011-11-24 Thread Alan Bateman
On 23/11/2011 20:48, David Holmes wrote: Alan, It's definitely tricky (lots of refactoring needed) but it definitely needs to be done at some point - however I think we already missed the opportunity to do this before integrating the BSD and MacOSX code (same on the VM side) I've often

Re: jdk/src/solaris - time to re-visit it?

2011-11-24 Thread Fredrik Öhrström
2011-11-24 11:11, Alan Bateman skrev: The immediate benefit of renaming is that it would allow us to move the Solaris and Linux specific source files out of the src/unix tree into src/platform directories. That would eliminate the need for some of the filtering in the build and would also

Re: jdk/src/solaris - time to re-visit it?

2011-11-24 Thread David Holmes
On 25/11/2011 12:39 AM, Fredrik Öhrström wrote: No-one answered my question if we need to track the posix pedigree? I.e. gnu, sysv and bsd? I would hope this would not be necessary. There would have to be a critical mass of duplicated code (say between Solaris and BSD) to warrant a further

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread Fredrik Öhrström
2011-11-23 13:12, Alan Bateman skrev: In the jdk repository then src/solaris has all the Solaris and Linux code. Most of it is used for both platforms with a small number of files specific to one or the other. I'm sure this has come up before (probably many times) but I'd like to bring it

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread Dmitry Samersoff
Alan, I'd thought about it couple of times (actually, every time i touched networking code) Unfortunately there is no simple solution because lots of code has huge common part and small platform specific function on top of it. Also with a course to expand platform coverage it's possible to end

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread Jonathan Gibbons
At the risk of including Yet Another alias, you should include build-infra-...@openjdk.java.net, for the team working on the new build system. -- Jon On 11/23/2011 06:40 AM, Dmitry Samersoff wrote: Alan, I'd thought about it couple of times (actually, every time i touched networking code)

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread Phil Race
Its tricky. I would not gratuitously change any of the directory names, especially the win32 one. There'd have to be a compelling reason. The Linux and Solaris ports share X11 for their windowing system, but the OS X port doesn't. So some mac things would go in src/solaris, as they are

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread David Holmes
Alan, It's definitely tricky (lots of refactoring needed) but it definitely needs to be done at some point - however I think we already missed the opportunity to do this before integrating the BSD and MacOSX code (same on the VM side) David On 23/11/2011 10:12 PM, Alan Bateman wrote: In