Re: jdk10 on macOS

2018-01-18 Thread Jonathan Gibbons
On 01/18/2018 05:51 PM, David Holmes wrote: On 19/01/2018 3:20 AM, Alan Snyder wrote: I tried building from the jdk repo (vs jdk10). The StringPlatformChars test passed. The other four tests appear to have been removed. However, I did get failures on these tests: • MethodHandleConstant

Re: jdk10 on macOS

2018-01-18 Thread David Holmes
On 19/01/2018 3:20 AM, Alan Snyder wrote: I tried building from the jdk repo (vs jdk10). The StringPlatformChars test passed. The other four tests appear to have been removed. However, I did get failures on these tests: • MethodHandleConstants (internal error: appendix) >• MethodR

Re: jdk10 on macOS

2018-01-18 Thread Alan Snyder
I tried building from the jdk repo (vs jdk10). The StringPlatformChars test passed. The other four tests appear to have been removed. However, I did get failures on these tests: • MethodHandleConstants (internal error: appendix) • JavadocHelperTest (out of memory — Java heap spac

Re: jdk10 on macOS

2018-01-17 Thread David Holmes
Alan, On 18/01/2018 6:52 AM, Alan Snyder wrote: To summarize, these are the test failures/errors: • StringPlatformChars (error — native code not found) This seems potentially a makefile issue. • NewUnsafeString (did not use provided string) • APIExtraction (class fil

Re: jdk10 on macOS

2018-01-17 Thread Alan Snyder
To summarize, these are the test failures/errors: • StringPlatformChars (error — native code not found) • NewUnsafeString (did not use provided string) • APIExtraction (class file for TestClass not found) • ClassDependenciesTest (assertion error — null pointer in lo

Re: jdk10 on macOS

2018-01-17 Thread Alan Snyder
I started from scratch using the sledgehammer approach and got the same results. > On Jan 17, 2018, at 4:16 AM, Magnus Ihse Bursie > wrote: > > > On 2018-01-16 17:28, Alan Snyder wrote: >> Is there some resolution to this? >> >> Is the JDK that I built valid despite the test failures? >> >

Re: jdk10 on macOS

2018-01-17 Thread Alan Snyder
Regarding your last point, it seems that the test image has been built, so perhaps the problem lies elsewhere. Alans-iMac:jdk10 alan$ ll build/*/images total 3344 drwxr-xr-x 81 alan staff 2754 Jan 5 10:41 gengraphs drwxr-xr-x 11 alan staff 374 Jan 5 10:42 jdk drwxr-xr-x 3 alan s

Re: jdk10 on macOS

2018-01-17 Thread Magnus Ihse Bursie
On 2018-01-16 17:28, Alan Snyder wrote: Is there some resolution to this? Is the JDK that I built valid despite the test failures? Are there problems with some tests or with the test scripts? If so, will the problems be fixed? I believe the problem is most likely to reside in your environme

Re: jdk10 on macOS

2018-01-16 Thread Alan Snyder
Is there some resolution to this? Is the JDK that I built valid despite the test failures? Are there problems with some tests or with the test scripts? If so, will the problems be fixed? > On Jan 9, 2018, at 9:39 AM, Alan Snyder wrote: > > I already tried make test-image; make run-test-tier1

Re: jdk10 on macOS

2018-01-09 Thread Alan Snyder
I already tried make test-image; make run-test-tier1 and it had no impact on the outcome. Given that, do you still want me to try your suggestion? Alan > On Jan 8, 2018, at 11:28 PM, Magnus Ihse Bursie > wrote: > > >> 8 jan. 2018 kl. 23:23 skrev David Holmes : >> >>> On 9/01/2018 4:35 AM

Re: jdk10 on macOS

2018-01-08 Thread Magnus Ihse Bursie
> 8 jan. 2018 kl. 23:23 skrev David Holmes : > >> On 9/01/2018 4:35 AM, Jonathan Gibbons wrote: >> Maybe the Makefile targets to run tests could report an up-front warning if >> the native libraries have not been built. > > Based on my observations the makefile target will also build the test-i

Re: jdk10 on macOS

2018-01-08 Thread David Holmes
On 9/01/2018 4:35 AM, Jonathan Gibbons wrote: Maybe the Makefile targets to run tests could report an up-front warning if the native libraries have not been built. Based on my observations the makefile target will also build the test-image if needed. David A more advanced solution would be

Re: jdk10 on macOS

2018-01-08 Thread Jonathan Gibbons
s like a problem using an older build of jtreg, from the Adopt OpenJDK group. The tell-tale evidence is the Class-Path entry in the jtreg.jar MANIFEST.MF file: does that entry include asmtools.jar? T

Re: jdk10 on macOS

2018-01-05 Thread Alan Snyder
Following the instructions for the impatient, I did make images and then make run-test-tier1. Then after replacing the jtreg with the one Jon recommended, I did make run-test-tier1 again. Alan > On Jan 5, 2018, at 6:32 PM, David Holmes wrote: > > On 6/01/2018 12:05 PM, Alan Snyder wrote: >

Re: jdk10 on macOS

2018-01-05 Thread David Holmes
he Adopt OpenJDK group. The tell-tale evidence is the Class-Path entry in the jtreg.jar MANIFEST.MF file: does that entry include asmtools.jar? There have been build changes for jtreg recently, that should have addressed this problem. If nothing else, it is now much easier to build jtreg yo

Re: jdk10 on macOS

2018-01-05 Thread Alan Snyder
The tests were run via make. > On Jan 5, 2018, at 4:13 PM, David Holmes wrote: > > Alan, > > Unclear how you ran the tests, but: > > TEST RESULT: Error. Use -nativepath to specify the location of native code > > indicates jtreg was not passed the -nativepath flag. That may or may not be a >

Re: jdk10 on macOS

2018-01-05 Thread David Holmes
wrote: That sounds like a problem using an older build of jtreg, from the Adopt OpenJDK group. The tell-tale evidence is the Class-Path entry in the jtreg.jar MANIFEST.MF file: does that entry include asmtools.jar? There have been build changes for jtreg recently, that should have addressed this pro

Re: jdk10 on macOS

2018-01-05 Thread David Holmes
vestigate what we can do to fix this. -- Jon On 01/05/2018 12:36 PM, Jonathan Gibbons wrote: That sounds like a problem using an older build of jtreg, from the Adopt OpenJDK group. The tell-tale evidence is the Class-Path entry in the jtreg.jar MANIFEST.MF file: does that entry include asmtool

Re: jdk10 on macOS

2018-01-05 Thread Alan Snyder
;>> On Jan 5, 2018, at 1:02 PM, Jonathan Gibbons >>> <mailto:jonathan.gibb...@oracle.com>> wrote: >>>> >>>> Alan, >>>> >>>> I confirm there are problems with the jtreg builds from the Adopt OpenJDK >>>> group. I&#x

Re: jdk10 on macOS

2018-01-05 Thread Alan Snyder
a problem using an older build of jtreg, from the Adopt >>>> OpenJDK group. The tell-tale evidence is the Class-Path entry in the >>>> jtreg.jar MANIFEST.MF file: does that entry include asmtools.jar? >>>> >>>> There have been build changes f

Re: jdk10 on macOS

2018-01-05 Thread Jonathan Gibbons
se will be downloaded, and built if necessary. -- Jon On 1/5/18 12:21 PM, Alan Snyder wrote: I am trying to build jdk10 on macOS 10.12.6. I got the basic build to work, but some tests fail. Most of the test failures complain about not finding jasm or jcoder. This is odd because I downloaded

Re: jdk10 on macOS

2018-01-05 Thread Alan Snyder
recent JDK, >> such as JDK 8. Everything else will be downloaded, and built if necessary. >> >> -- Jon >> >> >> On 1/5/18 12:21 PM, Alan Snyder wrote: >>> I am trying to build jdk10 on macOS 10.12.6. I got the basic build to work, >>> but some

Re: jdk10 on macOS

2018-01-05 Thread Jonathan Gibbons
s you need are Ant and a recent JDK, such as JDK 8. Everything else will be downloaded, and built if necessary. -- Jon On 1/5/18 12:21 PM, Alan Snyder wrote: I am trying to build jdk10 on macOS 10.12.6. I got the basic build to work, but some tests fail. Most of the test failures complain abou

Re: jdk10 on macOS

2018-01-05 Thread Jonathan Gibbons
problem. If nothing else, it is now much easier to build jtreg yourself. The only external components you need are Ant and a recent JDK, such as JDK 8. Everything else will be downloaded, and built if necessary. -- Jon On 1/5/18 12:21 PM, Alan Snyder wrote: I am trying to build jdk10 on macOS

jdk10 on macOS

2018-01-05 Thread Alan Snyder
I am trying to build jdk10 on macOS 10.12.6. I got the basic build to work, but some tests fail. Most of the test failures complain about not finding jasm or jcoder. This is odd because I downloaded jtreg-4.2-b11, which includes these classes, and the classpath appears to be correct in the log