Re: Need reviewer - Fixing -D quotes

2009-10-13 Thread Kelly O'Hair
Jonathan Gibbons wrote: Kelly O'Hair wrote: 6888709: Change use of -DX=\""Y\"" to -DX='"Y"', consistently for all platforms http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-quotes-6888709/webrev/ -kto For the record, you changed some quoting of { } as well, but still looks good

Re: 6856630: Restructure jaxp/jaxws repository

2009-10-13 Thread Andrew John Hughes
2009/10/12 Kelly O'Hair : > I saw the webrev for a while, and now I can't :^(, but I saw enough... > >>> Andrew John Hughes wrote: 2009/10/7 Andrew John Hughes : > > ...[snip]... I found a number of issues with the current version: * The drop zips are expected to be in

Re: Need reviewer - Fixing -D quotes

2009-10-13 Thread Tim Bell
Looks good to me as well- Tim Jonathan Gibbons wrote: > Kelly O'Hair wrote: >> 6888709: Change use of -DX=\""Y\"" to -DX='"Y"', consistently for all >> platforms >> >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-quotes-6888709/webrev/ >> >> >> -kto > > For the record, you changed some

Re: 6856630: Restructure jaxp/jaxws repository

2009-10-13 Thread Kelly O'Hair
I saw the webrev for a while, and now I can't :^(, but I saw enough... Andrew John Hughes wrote: 2009/10/7 Andrew John Hughes : ...[snip]... I found a number of issues with the current version: * The drop zips are expected to be in a share/jdk7-drops subdirectory of the devtools directory.