Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Kelly O'Hair
I need some formal reviewers on these jdk/test/Makefile changes. More polish and changes may need to be done later, but there is value in what I have now, and I need lots of help to improve things (and fix some of our testcases). Here is the bugid and webrev: 6888927: Fix jdk jtreg tests to in

Re: Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Jonathan Gibbons
Kelly, Wow, you've been busy. The thing that stood out to me was the use of SLASH_JAVA which is something of a Sun legacy which doesn't apply to folk outside Sun. And, looking at the file as a whole, it's clear there are many different sections, not all of which apply to the OpenJDK communit

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Andrew John Hughes
2009/11/3 Kelly O'Hair : > > If it is complaining about libjsig.so, > then you need this changeset in the jdk7/jdk repository. > > http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/8885b2256507 > > The Makefile jdk7/jdk/make/java/redist/Makefile is the jdk > Makefile that copies the hotspot build into a

Self-built JDK has troubles reading jar-files

2009-11-03 Thread Clemens Eisserer
Hello, I've just tried syncing with master, however my build doesn't seem to be able to handle jar-files - even with a fresh clone of jdk7/jdk or jdk//2d/jdk: [...@localhost linux-i586]$ bin/java -Dsun.java2d.xrender=True -jar /fc8/usr/j.jar Exception in thread "main" java.lang.NoClassDefFoundErr

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Andrew John Hughes
2009/11/3 Clemens Eisserer : > Hello, > > I've just tried syncing with master, however my build doesn't seem to > be able to handle jar-files - even with a fresh clone of jdk7/jdk or > jdk//2d/jdk: > > [...@localhost linux-i586]$ bin/java -Dsun.java2d.xrender=True -jar > /fc8/usr/j.jar > Exception

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Kelly O'Hair
I'm also doing a sync of the jdk7/jdk7 changes into jdk7/build. But it won't happen until tomorrow. -kto

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Kelly O'Hair
If it is complaining about libjsig.so, then you need this changeset in the jdk7/jdk repository. http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/8885b2256507 The Makefile jdk7/jdk/make/java/redist/Makefile is the jdk Makefile that copies the hotspot build into a jdk image. There was some recent cha

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Andrew John Hughes
2009/11/3 Clemens Eisserer : > Hi Andrew, > >> Difficult to say from just that.  Have you tried using the freshly >> built JDK to build itself?  It's a quick acid test of a new build, and >> something IcedTea does by default. > > I know thats no excuse, but I haven't played a lot with building Open

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Clemens Eisserer
Hi Andrew, > Difficult to say from just that.  Have you tried using the freshly > built JDK to build itself?  It's a quick acid test of a new build, and > something IcedTea does by default. I know thats no excuse, but I haven't played a lot with building OpenJDK. I was happy when I found a way to

Re: Self-built JDK has troubles reading jar-files

2009-11-03 Thread Tim Bell
Andrew John Hughes wrote: > There's still the FontManager issue with b75, so for now I'd recommend m5: > > http://hg.openjdk.java.net/jdk7/m5 > > which is currently b75 + build forest promotion + jsr166y It should be, but my fault - the m5 forest does not have the build changests yet, but it wi

Re: Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Martin Buchholz
On Tue, Nov 3, 2009 at 18:45, Jonathan Gibbons wrote: > > The thing that stood out to me was the use of SLASH_JAVA which is something > of a Sun legacy which doesn't apply to folk outside Sun. > I've been using SLASH_JAVA because it simplifies the job of organizing my jdk build dependencies. mak

Re: Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Martin Buchholz
One of the things you've done is to create "test sets". I did something like that in my "jtr" script (ask Tim if you can't find it). For each logical component, it's non-trivial to find all the tests for that (e.g. how to test string handling). This is especially true for shared directories like ja

Re: Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Tim Bell
Hi Kelly > I need some formal reviewers on these jdk/test/Makefile changes. > > More polish and changes may need to be done later, but there > is value in what I have now, and I need lots of help to improve > things (and fix some of our testcases). This is a great start. > Here is the bugid and